From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753220AbZENPbn (ORCPT ); Thu, 14 May 2009 11:31:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751317AbZENPbc (ORCPT ); Thu, 14 May 2009 11:31:32 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:36380 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbZENPbc (ORCPT ); Thu, 14 May 2009 11:31:32 -0400 Date: Thu, 14 May 2009 09:31:32 -0600 From: Matthew Wilcox To: David Woodhouse Cc: Fenghua Yu , "'Tony Luck'" , "'lkml'" , "'iommu'" , "'ia64'" Subject: Re: [PATCH] Fix Intel IOMMU Compilation Warnings on IA64 Message-ID: <20090514153132.GS15360@parisc-linux.org> References: <20090327212241.234500000@intel.com> <20090327212321.070229000@intel.com> <20090416001957.GA1527@linux-os.sc.intel.com> <1240135508.3589.75.camel@macbook.infradead.org> <20090513231351.GA22386@linux-os.sc.intel.com> <1242314271.3393.11.camel@macbook.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1242314271.3393.11.camel@macbook.infradead.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 14, 2009 at 04:17:51PM +0100, David Woodhouse wrote: > Perhaps this would be better, modelled after commit fe333321: > > +#ifdef __KERNEL__ > +#include > +#else > #include > +#endif It's certainly something I've been lobbying for for a while. There's various new warnings that crop up, and I wasn't able to log into the system Tony offered me to fix it on. Maybe someone who cares about ia64 these days could take care of fixing up the remaining warnings? I see http://kerneltrap.org/mailarchive/linux-ia64/2008/10/19/3945454 is out there. There might be a more recent version ... somewhere ... Perhaps Tony has a copy of it? -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."