public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org,
	linux-security-module@vger.kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
	Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
	Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Paul Moore <paul.moore@hp.com>
Subject: [patch 22/51] selinux: Remove dead code labeled networking code
Date: Thu, 14 May 2009 15:32:57 -0700	[thread overview]
Message-ID: <20090514223523.889593969@mini.kroah.org> (raw)
In-Reply-To: <20090514223755.GA27019@kroah.com>

[-- Attachment #1: selinux-remove-dead-code-labeled-networking-code.patch --]
[-- Type: text/plain, Size: 2793 bytes --]

2.6.29-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Paul Moore <paul.moore@hp.com>

[NOTE: based on 389fb800ac8be2832efedd19978a2b8ced37eb61]

Remove code that is no longer needed by NetLabel and/or SELinux.

Signed-off-by: Paul Moore <paul.moore@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

 security/selinux/netlabel.c |   77 --------------------------------------------
 1 file changed, 77 deletions(-)

--- a/security/selinux/netlabel.c
+++ b/security/selinux/netlabel.c
@@ -100,41 +100,6 @@ static struct netlbl_lsm_secattr *selinu
 }
 
 /**
- * selinux_netlbl_sock_setsid - Label a socket using the NetLabel mechanism
- * @sk: the socket to label
- *
- * Description:
- * Attempt to label a socket using the NetLabel mechanism.  Returns zero values
- * on success, negative values on failure.
- *
- */
-static int selinux_netlbl_sock_setsid(struct sock *sk)
-{
-	int rc;
-	struct sk_security_struct *sksec = sk->sk_security;
-	struct netlbl_lsm_secattr *secattr;
-
-	if (sksec->nlbl_state != NLBL_REQUIRE)
-		return 0;
-
-	secattr = selinux_netlbl_sock_genattr(sk);
-	if (secattr == NULL)
-		return -ENOMEM;
-	rc = netlbl_sock_setattr(sk, secattr);
-	switch (rc) {
-	case 0:
-		sksec->nlbl_state = NLBL_LABELED;
-		break;
-	case -EDESTADDRREQ:
-		sksec->nlbl_state = NLBL_REQSKB;
-		rc = 0;
-		break;
-	}
-
-	return rc;
-}
-
-/**
  * selinux_netlbl_cache_invalidate - Invalidate the NetLabel cache
  *
  * Description:
@@ -361,48 +326,6 @@ int selinux_netlbl_socket_post_create(st
 }
 
 /**
- * selinux_netlbl_inode_permission - Verify the socket is NetLabel labeled
- * @inode: the file descriptor's inode
- * @mask: the permission mask
- *
- * Description:
- * Looks at a file's inode and if it is marked as a socket protected by
- * NetLabel then verify that the socket has been labeled, if not try to label
- * the socket now with the inode's SID.  Returns zero on success, negative
- * values on failure.
- *
- */
-int selinux_netlbl_inode_permission(struct inode *inode, int mask)
-{
-	int rc;
-	struct sock *sk;
-	struct socket *sock;
-	struct sk_security_struct *sksec;
-
-	if (!S_ISSOCK(inode->i_mode) ||
-	    ((mask & (MAY_WRITE | MAY_APPEND)) == 0))
-		return 0;
-	sock = SOCKET_I(inode);
-	sk = sock->sk;
-	if (sk == NULL)
-		return 0;
-	sksec = sk->sk_security;
-	if (sksec == NULL || sksec->nlbl_state != NLBL_REQUIRE)
-		return 0;
-
-	local_bh_disable();
-	bh_lock_sock_nested(sk);
-	if (likely(sksec->nlbl_state == NLBL_REQUIRE))
-		rc = selinux_netlbl_sock_setsid(sk);
-	else
-		rc = 0;
-	bh_unlock_sock(sk);
-	local_bh_enable();
-
-	return rc;
-}
-
-/**
  * selinux_netlbl_sock_rcv_skb - Do an inbound access check using NetLabel
  * @sksec: the sock's sk_security_struct
  * @skb: the packet



  parent reply	other threads:[~2009-05-14 22:54 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090514223235.348540705@mini.kroah.org>
2009-05-14 22:37 ` [patch 00/51] 2.6.29-stable review Greg KH
2009-05-14 22:32   ` [patch 01/51] fiemap: fix problem with setting FIEMAP_EXTENT_LAST Greg KH
2009-05-14 22:32   ` [patch 02/51] md: remove ability to explicit set an inactive array to clean Greg KH
2009-05-14 22:32   ` [patch 03/51] md: fix some (more) errors with bitmaps on devices larger than 2TB Greg KH
2009-05-14 22:32   ` [patch 04/51] md/raid10: dont clear bitmap during recovery if array will still be degraded Greg KH
2009-05-14 22:32   ` [patch 05/51] md: fix loading of out-of-date bitmap Greg KH
2009-05-14 22:32   ` [patch 06/51] usb-serial: ftdi_sio: fix reference counting of ftdi_private Greg KH
2009-05-18 12:46     ` David Woodhouse
2009-05-18 23:33       ` [stable] " Greg KH
2009-05-14 22:32   ` [patch 07/51] USB: Gadget: fix UTF conversion in the usbstring library Greg KH
2009-05-14 22:32   ` [patch 08/51] ALSA: hda - Fix line-in on Mac Mini Core2 Duo Greg KH
2009-05-14 22:32   ` [patch 09/51] ASoC: Fix errors in WM8990 Greg KH
2009-05-14 22:32   ` [patch 10/51] e1000: fix virtualization bug Greg KH
2009-05-14 22:32   ` [patch 11/51] hwmon: (w83781d) Fix W83782D support (NULL pointer dereference) Greg KH
2009-05-14 22:32   ` [patch 12/51] Fix for enabling branch profiling makes sparse unusable Greg KH
2009-05-14 22:32   ` [patch 13/51] i2c-algo-bit: Fix timeout test Greg KH
2009-05-14 22:32   ` [patch 14/51] i2c-algo-pca: Let PCA9564 recover from unacked data byte (state 0x30) Greg KH
2009-05-14 22:32   ` [patch 15/51] dup2: Fix return value with oldfd == newfd and invalid fd Greg KH
2009-05-14 22:32   ` [patch 16/51] ne2k-pci: Do not register device until initialized Greg KH
2009-05-14 22:32   ` [patch 17/51] lsm: Relocate the IPv4 security_inet_conn_request() hooks Greg KH
2009-05-14 22:32   ` [patch 18/51] netlabel: Add CIPSO {set, del}attr request_sock functions Greg KH
2009-05-14 22:32   ` [patch 19/51] netlabel: Add new NetLabel KAPI interfaces for request_sock security attributes Greg KH
2009-05-14 22:32   ` [patch 20/51] selinux: Add new NetLabel glue code to handle labeling of connection requests Greg KH
2009-05-14 22:32   ` [patch 21/51] selinux: Set the proper NetLabel security attributes for " Greg KH
2009-05-14 22:32   ` Greg KH [this message]
2009-05-14 22:32   ` [patch 23/51] smack: " Greg KH
2009-05-14 22:32   ` [patch 24/51] cifs: Fix buffer size for tcon->nativeFileSystem field Greg KH
2009-05-14 22:33   ` [patch 25/51] cifs: Increase size of tmp_buf in cifs_readdir to avoid potential overflows Greg KH
2009-05-14 22:33   ` [patch 26/51] cifs: Fix incorrect destination buffer size in cifs_strncpy_to_host Greg KH
2009-05-14 22:33   ` [patch 27/51] cifs: Fix buffer size in cifs_convertUCSpath Greg KH
2009-05-14 22:33   ` [patch 28/51] cifs: Fix unicode string area word alignment in session setup Greg KH
2009-05-14 22:33   ` [patch 29/51] mac80211: pid, fix memory corruption Greg KH
2009-05-15  6:23     ` Jiri Slaby
2009-05-15 14:49       ` Greg KH
2009-05-15 15:09         ` Jiri Slaby
2009-05-18 23:33           ` [stable] " Greg KH
2009-05-15 21:49         ` Jiri Slaby
2009-06-09  8:18           ` [stable] " Greg KH
2009-05-14 22:33   ` [patch 30/51] mm: page_mkwrite change prototype to match fault Greg KH
2009-05-14 22:33   ` [patch 31/51] fs: fix page_mkwrite error cases in core code and btrfs Greg KH
2009-05-14 22:33   ` [patch 32/51] mm: close page_mkwrite races Greg KH
2009-05-14 22:33   ` [patch 33/51] GFS2: Fix page_mkwrite() return code Greg KH
2009-05-14 22:33   ` [patch 34/51] NFS: Fix the return value in nfs_page_mkwrite() Greg KH
2009-05-14 22:33   ` [patch 35/51] NFS: Close page_mkwrite() races Greg KH
2009-05-14 22:33   ` [patch 36/51] CIFS: Fix endian conversion of vcnum field Greg KH
2009-05-14 22:33   ` [patch 37/51] epoll: fix size check in epoll_create() Greg KH
2009-05-14 22:33   ` [patch 38/51] nfsd4: check for negative dentry before use in nfsv4 readdir Greg KH
2009-05-14 22:33   ` [patch 39/51] NFS: Fix the notifications when renaming onto an existing file Greg KH
2009-05-14 22:33   ` [patch 40/51] lockd: fix list corruption on lockd restart Greg KH
2009-05-14 22:33   ` [patch 41/51] dmatest: fix max channels handling Greg KH
2009-05-14 22:33   ` [patch 42/51] HID: add NOGET quirk for devices from CH Products Greg KH
2009-05-14 22:33   ` [patch 43/51] KVM: SVM: Remove port 80 passthrough Greg KH
2009-05-14 22:33   ` [patch 44/51] KVM: Make EFER reads safe when EFER does not exist Greg KH
2009-05-14 22:33   ` [patch 45/51] fuse: destroy bdi on error Greg KH
2009-05-14 22:33   ` [patch 46/51] splice: split up __splice_from_pipe() Greg KH
2009-05-14 22:33   ` [patch 47/51] splice: remove i_mutex locking in splice_from_pipe() Greg KH
2009-05-14 22:33   ` [patch 48/51] splice: fix i_mutex locking in generic_splice_write() Greg KH
2009-05-14 22:33   ` [patch 49/51] ocfs2: fix i_mutex locking in ocfs2_splice_to_file() Greg KH
2009-05-14 22:33   ` [patch 50/51] ehea: fix invalid pointer access Greg KH
2009-05-14 22:33   ` [patch 51/51] powerpc/5200: Dont specify IRQF_SHARED in PSC UART driver Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090514223523.889593969@mini.kroah.org \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=eteo@redhat.com \
    --cc=jake@lwn.net \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=paul.moore@hp.com \
    --cc=rbranco@la.checkpoint.com \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=w@1wt.eu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox