From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Li Zefan <lizf@cn.fujitsu.com>
Subject: [PATCH 4/4] tracing/filters: fix off-by-one bug
Date: Fri, 15 May 2009 00:05:58 -0400 [thread overview]
Message-ID: <20090515040747.107781601@goodmis.org> (raw)
In-Reply-To: 20090515040554.074680910@goodmis.org
[-- Attachment #1: 0004-tracing-filters-fix-off-by-one-bug.patch --]
[-- Type: text/plain, Size: 957 bytes --]
From: Li Zefan <lizf@cn.fujitsu.com>
We should leave the last slot for the ending '\0'.
[ Impact: fix possible crash when the length of an operand is 128 ]
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4A0CDC8C.30602@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_events_filter.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 22c2998..a7430b1 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -736,7 +736,7 @@ static inline void clear_operand_string(struct filter_parse_state *ps)
static inline int append_operand_char(struct filter_parse_state *ps, char c)
{
- if (ps->operand.tail == MAX_FILTER_STR_VAL)
+ if (ps->operand.tail == MAX_FILTER_STR_VAL - 1)
return -EINVAL;
ps->operand.string[ps->operand.tail++] = c;
--
1.6.2.4
--
next prev parent reply other threads:[~2009-05-15 4:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 4:05 [PATCH 0/4] [GIT PULL] tracing: small updates for tip Steven Rostedt
2009-05-15 4:05 ` [PATCH 1/4] x86/stacktrace: return 0 instead of -1 for stack ops Steven Rostedt
2009-05-15 4:05 ` [PATCH 2/4] tracing: stop stack trace on first empty entry Steven Rostedt
2009-05-15 4:05 ` [PATCH 3/4] tracing/filters: add missing unlock in a failure path Steven Rostedt
2009-05-15 4:05 ` Steven Rostedt [this message]
2009-05-15 14:25 ` [PATCH 0/4] [GIT PULL] tracing: small updates for tip Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515040747.107781601@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox