Re: [Patch 00/12] Hardware Breakpoint interfaces

Alan Stern
2009-05-14T20:02:26Z

On Wed, 13 May 2009, K.Prasad wrote:

> Hi Alan,
> Please find a new set of patches with the following changes.
> I am eager to know if you think that they are ready for submission towards
> upstream acceptance.

This is looking pretty good. Only one thing caught my eye:
switch_to_thread_hw_breakpoint and switch_to_none_hw_breakpoint do
nothing but call the corresponding arch-specific routines. You might
as well eliminate them and have the callers invoke the arch-specific
routines instead.

Alan Stern