From: Christoph Hellwig <hch@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC] tracing: adding flags to events
Date: Fri, 15 May 2009 12:57:56 -0400 [thread overview]
Message-ID: <20090515165756.GA29760@infradead.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0905141535360.30591@gandalf.stny.rr.com>
Nice!
I gave it a try in the xfs tracer and it seems to work fine. One little
suggestion, can we specifies the flags as the full value instead of bit
positions? That's how the are specified in the enums/#defines naming
them (either in the 1<<n scheme or the 0x000n scheme) and translating
between the two is a bit cumbersome.
For some reason using it gives me warnings ala:
fs/xfs/linux-2.6/./xfs_trace.h: In function 'ftrace_raw_output_xfs_attr':
fs/xfs/linux-2.6/./xfs_trace.h:48: warning: array subscript is below array bounds
these look surprisingy similar to bogus gcc warnings I have in a couple
of other places in my build, just that here it's in generated code, so
it's hard to check the validity.
prev parent reply other threads:[~2009-05-15 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 19:45 [RFC] tracing: adding flags to events Steven Rostedt
2009-05-14 20:33 ` Frederic Weisbecker
2009-05-14 23:18 ` Steven Rostedt
2009-05-14 23:58 ` Frederic Weisbecker
2009-05-15 0:01 ` Steven Rostedt
2009-05-15 0:20 ` Frederic Weisbecker
2009-05-15 2:18 ` Li Zefan
2009-05-15 2:27 ` Steven Rostedt
2009-05-15 16:57 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515165756.GA29760@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox