From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 3/3] tracing: add flag output for kmem events
Date: Sat, 16 May 2009 02:40:40 +0300 [thread overview]
Message-ID: <20090515234040.GB3645@localhost> (raw)
In-Reply-To: <20090515210718.211132919@goodmis.org>
On Fri, May 15, 2009 at 05:03:45PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@redhat.com>
>
> This patch changes the output for gfp_flags from being a simple hex value
> to the actual names.
>
> gfp_flags=GFP_ATOMIC instead of gfp_flags=00000020
>
> And even
>
> gfp_flags=GFP_KERNEL instead of gfp_flags=000000d0
>
> [ Impact: more human readable output from tracer ]
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> include/trace/events/kmem.h | 43 +++++++++++++++++++++++++++++++++++--------
> 1 files changed, 35 insertions(+), 8 deletions(-)
As long as it doesn't touch (and I see it doesn't) the raw kmemtrace
output for kmemtrace-user, I'm okay with this sort of changes.
Acked-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
next prev parent reply other threads:[~2009-05-15 23:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 21:03 [PATCH 0/3] tracing/events: enumerating flags Steven Rostedt
2009-05-15 21:03 ` [PATCH 1/3] tracing: add __print_flags for events Steven Rostedt
2009-05-18 17:38 ` Christoph Hellwig
2009-05-20 22:13 ` Steven Rostedt
2009-05-20 22:59 ` Christoph Hellwig
2009-05-20 23:02 ` Steven Rostedt
2009-05-20 23:04 ` Christoph Hellwig
2009-05-21 1:10 ` KOSAKI Motohiro
2009-05-15 21:03 ` [PATCH 2/3] tracing: add previous task state info to sched switch event Steven Rostedt
2009-05-15 21:03 ` [PATCH 3/3] tracing: add flag output for kmem events Steven Rostedt
2009-05-15 21:23 ` Frederic Weisbecker
2009-05-15 21:50 ` Steven Rostedt
2009-05-15 23:40 ` Eduard - Gabriel Munteanu [this message]
2009-05-15 23:52 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515234040.GB3645@localhost \
--to=eduard.munteanu@linux360.ro \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox