public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Ming Lei <tom.leiming@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] kernel/async.c:introduce async_schedule*_atomic
Date: Sun, 17 May 2009 21:18:52 -0700	[thread overview]
Message-ID: <20090517211852.718059c5@infradead.org> (raw)
In-Reply-To: <d82e647a0905171855x79850a5bv7262f9e698d8b3f7@mail.gmail.com>

On Mon, 18 May 2009 09:55:14 +0800
Ming Lei <tom.leiming@gmail.com> wrote:

> >
> > in cases where you don't want to fail while in the atomic portion,
> > but can fail better earlier.
> 
> If we do this way, the type of async_schedule*()  and
> async_schedule*_inatomic() is different, and callers will be messed
> with them, especially for _inatomic().

I'm not so much proposing the external "simple API" to have this,
but the primitive should have it, so that we can provide a
__async_schedule_inatomic() which does have the option..


> 
> BTW: I have submited new version of this patches, would you mind
> giving a review?

I gave comments on various threads from my inbox, but I cannot rule out
having missed one... If you think I missed one, could you send me a 
private email with the latest patches you want reviewed (even if it's a
forward from what you sent earlier)?

I'm happy to see these enhancements btw...


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

      reply	other threads:[~2009-05-18  4:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-12 15:13 [PATCH] kernel/async.c:introduce async_schedule*_atomic tom.leiming
2009-05-12 15:44 ` Frederic Weisbecker
2009-05-12 15:58   ` Américo Wang
2009-05-13  0:36     ` Ming Lei
2009-05-12 16:04   ` Frederic Weisbecker
2009-05-12 16:31     ` Cornelia Huck
2009-05-12 16:52       ` Frederic Weisbecker
2009-05-12 17:18         ` Cornelia Huck
2009-05-13  0:28           ` Ming Lei
2009-05-13  1:20             ` Frederic Weisbecker
2009-05-13  7:47               ` Cornelia Huck
2009-05-17 20:59                 ` Arjan van de Ven
2009-05-18 11:29                   ` Cornelia Huck
2009-05-13  3:27           ` Ming Lei
2009-05-13  0:16     ` Ming Lei
2009-05-17 20:26 ` Arjan van de Ven
2009-05-18  1:55   ` Ming Lei
2009-05-18  4:18     ` Arjan van de Ven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090517211852.718059c5@infradead.org \
    --to=arjan@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox