From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: tom.leiming@gmail.com
Cc: arjan@infradead.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH 2/2] driver core:firmware:fix request_firmware_nowait
Date: Mon, 18 May 2009 13:15:24 +0200 [thread overview]
Message-ID: <20090518131524.6e63f3e6@gondolin> (raw)
In-Reply-To: <1242482058-5203-2-git-send-email-tom.leiming@gmail.com>
On Sat, 16 May 2009 21:54:18 +0800,
tom.leiming@gmail.com wrote:
> @@ -646,14 +646,12 @@ request_firmware_nowait(
> .uevent = uevent,
> };
>
> - task = kthread_run(request_firmware_work_func, fw_work,
> - "firmware/%s", name);
> -
> - if (IS_ERR(task)) {
> + ret = async_run_inatomic(request_firmware_work_func, fw_work);
> + if (ret) {
> fw_work->cont(NULL, fw_work->context);
> module_put(fw_work->module);
> kfree(fw_work);
> - return PTR_ERR(task);
> + return ret;
You change the return code from an usual error code to a boolean value
here...
> }
> return 0;
> }
next prev parent reply other threads:[~2009-05-18 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 13:54 [PATCH 1/2] kernel:async function call:introduce async_run_inatomic(v3) tom.leiming
2009-05-16 13:54 ` [PATCH 2/2] driver core:firmware:fix request_firmware_nowait tom.leiming
2009-05-18 11:15 ` Cornelia Huck [this message]
2009-05-18 11:10 ` [PATCH 1/2] kernel:async function call:introduce async_run_inatomic(v3) Cornelia Huck
2009-05-18 13:58 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518131524.6e63f3e6@gondolin \
--to=cornelia.huck@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox