public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Randy Dunlap <randy.dunlap@oracle.com>, Zorael <zorael@gmail.com>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [i915] Kernel does not compile when set to use i915 kernel mode-setting per default (CONFIG_DRM_I915_KMS=y)
Date: Mon, 18 May 2009 21:59:12 +0200	[thread overview]
Message-ID: <200905182159.12575.rjw@sisk.pl> (raw)
In-Reply-To: <20090518121140.d0bacafd.randy.dunlap@oracle.com>

On Monday 18 May 2009, Randy Dunlap wrote:
> On Mon, 18 May 2009 21:01:06 +0200 Rafael J. Wysocki wrote:
> 
> > Adding CCs.
> > 
> > On Monday 18 May 2009, you wrote:
> > > (First post, so please CC to zorael@gmail.com in case it doesn't automatically.)
> > > 
> > > 
> > > I'm trying to compile 2.6.30-rc6 to enable kernel mode-setting *per
> > > default*, for my Intel 945GME video chipset. Alas, when compiling, it
> > > halts with the following tidbit:
> > > 
> > > ...
> > >   LD      .tmp_vmlinux1
> > > drivers/built-in.o: In function `intel_opregion_free':
> > > /usr/src/linux/drivers/gpu/drm/i915/i915_opregion.c:422: undefined
> > > reference to `acpi_video_exit'
> > > drivers/built-in.o: In function `intel_opregion_init':
> > > /usr/src/linux/drivers/gpu/drm/i915/i915_opregion.c:393: undefined
> > > reference to `acpi_video_register'
> > > make[1]: *** [.tmp_vmlinux1] Error 1
> > > make[1]: Leaving directory `/usr/src/linux-2.6.29'
> > > make: *** [debian/stamp/build/kernel] Error 2
> > > 
> > > 
> > > grepping acpi_video_register recursively I see it's defined as an
> > > empty function in ./include/acpi/video.h, and as a more proper
> > > function in ./drivers/acpi/video.c. Does somehow setting it to use KMS
> > > per default via CONFIG_DRM_I915_KMS=y stop it from reading those
> > > files?
> > > 
> > > I used to run with KMS by default in the early -30rc*s, but at some
> > > point (rc2?), it stopped compiling succesfully. If I don't enable it
> > > per default, it *does* compile, though I don't know how to explicitly
> > > enable it at boot-time. So I'm living without KMS for the time being.
> > > Woe.
> > > 
> > > Anything obvious I'm doing wrong?
> 
> 
> Len posted a patch for this.  It's below.
> Len, do you have this patch queued for Linus?

Ah, it's commit ecb4aed78dcf09e48c8c34c8c2fa7f5c69344be6, which went in
slightly after -rc6.  So it should be fixed.

Zorael, please test the current Linus' tree.

Thanks,
Rafael

  reply	other threads:[~2009-05-18 19:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-18 18:09 [i915] Kernel does not compile when set to use i915 kernel mode-setting per default (CONFIG_DRM_I915_KMS=y) Zorael
2009-05-18 19:01 ` Rafael J. Wysocki
2009-05-18 19:10   ` Peter Zijlstra
2009-05-18 19:11   ` Randy Dunlap
2009-05-18 19:59     ` Rafael J. Wysocki [this message]
2009-05-20 19:30       ` Woody Suwalski
2009-05-20 19:52         ` Randy Dunlap
2009-05-20 20:15           ` Woody Suwalski
2009-05-20 21:27             ` Randy Dunlap
2009-05-30  1:13               ` Len Brown
2009-06-01 14:13                 ` Woody Suwalski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905182159.12575.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=zorael@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox