From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754606AbZESKdk (ORCPT ); Tue, 19 May 2009 06:33:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753687AbZESKdd (ORCPT ); Tue, 19 May 2009 06:33:33 -0400 Received: from mga14.intel.com ([143.182.124.37]:43896 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbZESKdc (ORCPT ); Tue, 19 May 2009 06:33:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.41,214,1241420400"; d="scan'208";a="144423777" Date: Tue, 19 May 2009 18:32:53 +0800 From: Wu Fengguang To: Johannes Weiner Cc: Andrew Morton , LKML , Peter Zijlstra , Christoph Lameter , KOSAKI Motohiro , "riel@redhat.com" , "tytso@mit.edu" , "linux-mm@kvack.org" , "elladan@eskimo.com" , "npiggin@suse.de" , "minchan.kim@gmail.com" Subject: Re: [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list() Message-ID: <20090519103253.GA2667@localhost> References: <20090517022327.280096109@intel.com> <20090517022742.320921900@intel.com> <20090518091653.GB10439@localhost> <20090519024316.GA7562@localhost> <20090519101833.GA1872@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090519101833.GA1872@cmpxchg.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2009 at 06:18:33PM +0800, Johannes Weiner wrote: > On Tue, May 19, 2009 at 10:43:16AM +0800, Wu Fengguang wrote: > > @@ -1283,6 +1319,7 @@ static void shrink_active_list(unsigned > > * are ignored, since JVM can create lots of anon > > * VM_EXEC pages. > > */ > > + if (page_cluster) > > if ((vm_flags & VM_EXEC) && !PageAnon(page)) { > > list_add(&page->lru, &l_active); > > continue; > > Huh, what's with that hunk? Ah, sorry, that's a handy debugging knob ;)