From: Frederic Weisbecker <fweisbec@gmail.com>
To: "K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [Patch 2/2] Fix the style issue seen in ksym tracer ftrace plugin
Date: Wed, 20 May 2009 01:14:21 +0200 [thread overview]
Message-ID: <20090519231418.GA6066@nowhere> (raw)
In-Reply-To: <20090519162558.GC26009@in.ibm.com>
On Tue, May 19, 2009 at 09:55:58PM +0530, K.Prasad wrote:
> Fix the style issue seen in ksym tracer ftrace plugin
>
> Move the extern 'process_new_ksym_entry' declaration from
> trace_selftest.c to trace.h file due to a reported style issue.
>
> Signed-off-by: K.Prasad <prasad@linux.vnet.ibm.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> kernel/trace/trace.h | 1 +
> kernel/trace/trace_selftest.c | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-tip.hbkpt/kernel/trace/trace.h
> ===================================================================
> --- linux-2.6-tip.hbkpt.orig/kernel/trace/trace.h
> +++ linux-2.6-tip.hbkpt/kernel/trace/trace.h
> @@ -213,6 +213,7 @@ struct syscall_trace_exit {
> };
>
> #define KSYM_SELFTEST_ENTRY "ksym_selftest_dummy"
> +extern int process_new_ksym_entry(char *ksymname, int op, unsigned long addr);
>
> struct trace_ksym {
> struct trace_entry ent;
> Index: linux-2.6-tip.hbkpt/kernel/trace/trace_selftest.c
> ===================================================================
> --- linux-2.6-tip.hbkpt.orig/kernel/trace/trace_selftest.c
> +++ linux-2.6-tip.hbkpt/kernel/trace/trace_selftest.c
> @@ -810,7 +810,6 @@ trace_selftest_startup_hw_branches(struc
> #endif /* CONFIG_HW_BRANCH_TRACER */
>
> #ifdef CONFIG_KSYM_TRACER
> -extern int process_new_ksym_entry(char *ksymname, int op, unsigned long addr);
> static int ksym_selftest_dummy;
>
> int
>
prev parent reply other threads:[~2009-05-19 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090519161720.374172804@prasadkr_t60p.in.ibm.com>
2009-05-19 16:24 ` [Patch 1/2] Improvements and minor fixes to HW Breakpoint interface K.Prasad
2009-05-19 18:09 ` Alan Stern
2009-05-20 10:55 ` K.Prasad
2009-05-20 14:04 ` Alan Stern
2009-05-20 16:45 ` K.Prasad
2009-05-20 17:53 ` Alan Stern
2009-05-19 16:25 ` [Patch 2/2] Fix the style issue seen in ksym tracer ftrace plugin K.Prasad
2009-05-19 23:14 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519231418.GA6066@nowhere \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).