From: Frederic Weisbecker <fweisbec@gmail.com>
To: "K.Prasad" <prasad@linux.vnet.ibm.com>, Ingo Molnar <mingo@elte.hu>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [Patch 0/2] Improvements and fixes to HW Breakpoint interface
Date: Wed, 20 May 2009 01:24:39 +0200 [thread overview]
Message-ID: <20090519232437.GB6066@nowhere> (raw)
In-Reply-To: <20090519162353.GA26009@in.ibm.com>
On Tue, May 19, 2009 at 09:53:53PM +0530, K.Prasad wrote:
> Hi Alan,
> Please find a couple of patches that contain improvements to the HW Breakpoint
> interface code (discovered while porting the infrastructure on another architecture)
> and a minor fix - the details of which are described in the patch header.
>
> These patches can be applied over the patchset submitted over -tip here:
> http://lkml.org/lkml/2009/5/15/139.
>
> As they carry some of your suggestions, I will be glad to have it reviewed by you.
>
> Hi Frederic,
> There's a minor style issue in the ksym tracer plugin (declaration of a
> function in .c file) which has now been corrected. Kindly review the same.
The ftrace part looks good, indeed such style issue is usually warned by checkpatch.pl
Thanks.
Ingo,
What do you think of the current state of the hardware breakpoint patchset?
If I'm not wrong, it has not yet been applied in -tip. Do you have mixed
feelings about it?
IIRC it has been mostly (fully?) acked by Alan Stern, I've also reviewed
the ftrace patch.
Frederic.
prev parent reply other threads:[~2009-05-19 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 16:23 [Patch 0/2] Improvements and fixes to HW Breakpoint interface K.Prasad
2009-05-19 23:24 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090519232437.GB6066@nowhere \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).