Re: [PATCH] tracing: use strlcpy instead of strncpy

Stefan Richter
2009-05-19T12:55:25Z

Lai Jiangshan wrote:
> [Impact] cleanup

Well, not entirely.

> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -155,8 +155,8 @@ struct trace_boot_ret {
> struct trace_branch {
> struct trace_entry ent;
> unsigned line;
> - char func[TRACE_FUNC_SIZE+1];
> - char file[TRACE_FILE_SIZE+1];
> + char func[TRACE_FUNC_SIZE];
> + char file[TRACE_FILE_SIZE];
> char correct;
> };

(without change of the TRACE_????_SIZE definition)

Better avoid a categorization of a patch if the change's scope exceeds
that of the categorization.
--
Stefan Richter
-=====-=-=== -=-= -==-=