Re: [PATCH] tracing: use strlcpy instead of strncpy

Lai Jiangshan
2009-05-20T02:37:25Z

Stefan Richter wrote:
> Lai Jiangshan wrote:
>> [Impact] cleanup
>
> Well, not entirely.
>
>> --- a/kernel/trace/trace.h
>> +++ b/kernel/trace/trace.h
>> @@ -155,8 +155,8 @@ struct trace_boot_ret {
>> struct trace_branch {
>> struct trace_entry ent;
>> unsigned line;
>> - char func[TRACE_FUNC_SIZE+1];
>> - char file[TRACE_FILE_SIZE+1];
>> + char func[TRACE_FUNC_SIZE];
>> + char file[TRACE_FILE_SIZE];
>> char correct;
>> };
>
> (without change of the TRACE_????_SIZE definition)
>
> Better avoid a categorization of a patch if the change's scope exceeds
> that of the categorization.

I think it's make no sense to change the magic number TRACE_????_SIZE,
I will rewrite my changelog as Frederic suggests.

Thank you very much.

Lai.