linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>, Elladan <elladan@eskimo.com>,
	Nick Piggin <npiggin@suse.de>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Rik van Riel <riel@redhat.com>, "tytso@mit.edu" <tytso@mit.edu>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"minchan.kim@gmail.com" <minchan.kim@gmail.com>
Subject: Re: [PATCH 2/3] vmscan: make mapped executable pages the first class  citizen
Date: Wed, 20 May 2009 09:44:45 +0800	[thread overview]
Message-ID: <20090520014445.GA7645@localhost> (raw)
In-Reply-To: <2f11576a0905190528n5eb29e3fme42785a76eed3551@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3294 bytes --]

On Tue, May 19, 2009 at 08:28:28PM +0800, KOSAKI Motohiro wrote:
> Hi
> 
> 2009/5/19 Wu Fengguang <fengguang.wu@intel.com>:
> > On Tue, May 19, 2009 at 04:06:35PM +0800, KOSAKI Motohiro wrote:
> >> > > > Like the console mode, the absolute nr_mapped drops considerably - to 1/13 of
> >> > > > the original size - during the streaming IO.
> >> > > >
> >> > > > The delta of pgmajfault is 3 vs 107 during IO, or 236 vs 393 during the whole
> >> > > > process.
> >> > >
> >> > > hmmm.
> >> > >
> >> > > about 100 page fault don't match Elladan's problem, I think.
> >> > > perhaps We missed any addional reproduce condition?
> >> >
> >> > Elladan's case is not the point of this test.
> >> > Elladan's IO is use-once, so probably not a caching problem at all.
> >> >
> >> > This test case is specifically devised to confirm whether this patch
> >> > works as expected. Conclusion: it is.
> >>
> >> Dejection ;-)
> >>
> >> The number should address the patch is useful or not. confirming as expected
> >> is not so great.
> >
> > OK, let's make the conclusion in this way:
> >
> > The changelog analyzed the possible beneficial situation, and this
> > test backs that theory with real numbers, ie: it successfully stops
> > major faults when the active file list is slowly scanned when there
> > are partially cache hot streaming IO.
> >
> > Another (amazing) finding of the test is, only around 1/10 mapped pages
> > are actively referenced in the absence of user activities.
> >
> > Shall we protect the remaining 9/10 inactive ones? This is a question ;-)
> 
> Unfortunately, I don't reproduce again.
> I don't apply your patch yet. but mapped ratio is reduced only very little.

mapped ratio or absolute numbers? The ratio wont change much because
nr_mapped is already small.

> I think smem can show which library evicted.  Can you try it?
> 
> download:  http://www.selenic.com/smem/
> usage:   ./smem -m -r --abbreviate

Sure, but I don't see much change in its output (see attachments).

smem-console-0 is collected after fresh boot,
smem-console-1 is collected after the big IO.

> We can't decide 9/10 is important or not. we need know actual evicted file list.

Right. But what I measured is the activeness. Almost zero major page
faults means the evicted 90% mapped pages are inactive during the
long 300 seconds of IO.

Thanks,
Fengguang

> > Or, shall we take the "protect active VM_EXEC mapped pages" approach,
> > or Christoph's "protect all mapped pages all time, unless they grow
> > too large" attitude?  I still prefer the best effort VM_EXEC heuristics.
> >
> > 1) the partially cache hot streaming IO is far more likely to happen
> >   on (file) servers. For them, evicting the 9/10 inactive mapped
> >   pages over night should be acceptable for sysadms.
> >
> > 2) for use-once IO on desktop, we have Rik's active file list
> >   protection heuristics, so nothing to worry at all.
> >
> > 3) for big working set small memory desktop, the active list will
> >   still be scanned, in this situation, why not evict some of the
> >   inactive mapped pages? If they have not been accessed for 1 minute,
> >   they are not likely be the user focus, and the tight memory
> >   constraint can only afford to cache the user focused working set.
> >
> > Does that make sense?

[-- Attachment #2: smem-console-0 --]
[-- Type: text/plain, Size: 2376 bytes --]

Map                                       PIDs   AVGPSS      PSS 
[heap]                                       2     1.5M     2.9M 
<anonymous>                                  2   538.0K     1.1M 
/usr/bin/python2.5                           1     1.0M     1.0M 
/bin/zsh4                                    1   592.0K   592.0K 
/usr/lib/zsh/4.3.9/zsh/zle.so                1   216.0K   216.0K 
/lib/libncursesw.so.5.7                      1   156.0K   156.0K 
/lib/libc-2.9.so                             2    65.0K   130.0K 
[stack]                                      2    62.0K   124.0K 
/usr/lib/zsh/4.3.9/zsh/complete.so           1    56.0K    56.0K 
/usr/lib/locale/locale-archive               2    28.0K    56.0K 
/usr/lib/python2.5/lib-dynload/operator.     1    32.0K    32.0K 
/lib/libm-2.9.so                             2    15.0K    30.0K 
/usr/lib/zsh/4.3.9/zsh/complist.so           1    28.0K    28.0K 
/lib/ld-2.9.so                               2    13.0K    26.0K 
/usr/lib/zsh/4.3.9/zsh/parameter.so          1    24.0K    24.0K 
/usr/lib/python2.5/lib-dynload/_struct.s     1    24.0K    24.0K 
/usr/lib/zsh/4.3.9/zsh/zutil.so              1    20.0K    20.0K 
/usr/lib/python2.5/lib-dynload/time.so       1    20.0K    20.0K 
/usr/lib/python2.5/lib-dynload/strop.so      1    20.0K    20.0K 
/usr/lib/python2.5/lib-dynload/_locale.s     1    20.0K    20.0K 
/lib/libpthread-2.9.so                       1    18.0K    18.0K 
/lib/libdl-2.9.so                            2     9.0K    18.0K 
/usr/lib/zsh/4.3.9/zsh/rlimits.so            1    16.0K    16.0K 
/lib/libcap.so.2.11                          1    16.0K    16.0K 
/lib/libattr.so.1.1.0                        1    16.0K    16.0K 
/usr/lib/zsh/4.3.9/zsh/terminfo.so           1    12.0K    12.0K 
/usr/lib/python2.5/lib-dynload/grp.so        1    12.0K    12.0K 
/lib/libutil-2.9.so                          1    11.0K    11.0K 
/lib/libnss_nis-2.9.so                       1    11.0K    11.0K 
/lib/libnss_files-2.9.so                     1    10.0K    10.0K 
/lib/libnss_compat-2.9.so                    1    10.0K    10.0K 
/lib/libnsl-2.9.so                           1    10.0K    10.0K 
/usr/lib/gconv/gconv-modules.cache           1     5.0K     5.0K 
[vsyscall]                                   2        0        0 
[vdso]                                       2        0        0 

[-- Attachment #3: smem-console-1 --]
[-- Type: text/plain, Size: 2376 bytes --]

Map                                       PIDs   AVGPSS      PSS 
[heap]                                       2     1.5M     2.9M 
<anonymous>                                  2   538.0K     1.1M 
/usr/bin/python2.5                           1     1.0M     1.0M 
/bin/zsh4                                    1   496.0K   496.0K 
/lib/libc-2.9.so                             2   180.0K   360.0K 
[stack]                                      2    60.0K   120.0K 
/lib/ld-2.9.so                               2    58.0K   116.0K 
/usr/lib/zsh/4.3.9/zsh/zle.so                1   112.0K   112.0K 
/lib/libncursesw.so.5.7                      1    56.0K    56.0K 
/usr/lib/locale/locale-archive               2    26.0K    52.0K 
/lib/libpthread-2.9.so                       1    48.0K    48.0K 
/lib/libm-2.9.so                             2    21.0K    42.0K 
/usr/lib/python2.5/lib-dynload/operator.     1    32.0K    32.0K 
/usr/lib/zsh/4.3.9/zsh/complete.so           1    24.0K    24.0K 
/usr/lib/python2.5/lib-dynload/_struct.s     1    24.0K    24.0K 
/lib/libdl-2.9.so                            2    12.0K    24.0K 
/usr/lib/python2.5/lib-dynload/time.so       1    20.0K    20.0K 
/usr/lib/python2.5/lib-dynload/strop.so      1    20.0K    20.0K 
/usr/lib/python2.5/lib-dynload/_locale.s     1    20.0K    20.0K 
/lib/libutil-2.9.so                          1    16.0K    16.0K 
/usr/lib/python2.5/lib-dynload/grp.so        1    12.0K    12.0K 
/lib/libcap.so.2.11                          1    12.0K    12.0K 
/lib/libnss_compat-2.9.so                    1     9.0K     9.0K 
/usr/lib/zsh/4.3.9/zsh/zutil.so              1     8.0K     8.0K 
/usr/lib/zsh/4.3.9/zsh/rlimits.so            1     8.0K     8.0K 
/lib/libnss_nis-2.9.so                       1     8.0K     8.0K 
/lib/libnss_files-2.9.so                     1     8.0K     8.0K 
/lib/libnsl-2.9.so                           1     8.0K     8.0K 
/usr/lib/zsh/4.3.9/zsh/terminfo.so           1     4.0K     4.0K 
/usr/lib/zsh/4.3.9/zsh/parameter.so          1     4.0K     4.0K 
/usr/lib/zsh/4.3.9/zsh/complist.so           1     4.0K     4.0K 
/lib/libattr.so.1.1.0                        1     4.0K     4.0K 
[vsyscall]                                   2        0        0 
[vdso]                                       2        0        0 
/usr/lib/gconv/gconv-modules.cache           1        0        0 

  reply	other threads:[~2009-05-20  1:45 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-16  9:00 [PATCH 0/3] make mapped executable pages the first class citizen Wu Fengguang
2009-05-16  9:00 ` [PATCH 1/3] vmscan: report vm_flags in page_referenced() Wu Fengguang
2009-05-16 13:17   ` Johannes Weiner
2009-05-16 13:37   ` Rik van Riel
2009-05-17  0:35   ` Minchan Kim
2009-05-17  1:36   ` Minchan Kim
2009-05-17  1:58     ` Wu Fengguang
2009-05-16  9:00 ` [PATCH 2/3] vmscan: make mapped executable pages the first class citizen Wu Fengguang
2009-05-16  9:28   ` Wu Fengguang
2009-05-16 13:20     ` Johannes Weiner
2009-05-17  0:38     ` Minchan Kim
2009-05-18 14:46     ` Christoph Lameter
2009-05-19  3:27       ` Wu Fengguang
2009-05-19  4:41         ` KOSAKI Motohiro
2009-05-19  4:44           ` KOSAKI Motohiro
2009-05-19  4:48             ` Wu Fengguang
2009-05-19  5:09           ` Wu Fengguang
2009-05-19  6:27             ` Wu Fengguang
2009-05-19  6:25           ` Wu Fengguang
2009-05-20 11:20             ` Andi Kleen
2009-05-20 14:32               ` Wu Fengguang
2009-05-20 14:47                 ` Andi Kleen
2009-05-20 14:56                   ` Wu Fengguang
2009-05-20 15:38                     ` Wu Fengguang
2009-06-08 12:14                       ` Nai Xia
2009-06-08 12:46                         ` Wu Fengguang
2009-06-08 15:02                           ` Nai Xia
2009-06-08  7:39               ` Wu Fengguang
2009-06-08  7:51                 ` KOSAKI Motohiro
2009-06-08  7:56                   ` Wu Fengguang
2009-06-08 17:18                 ` Nai Xia
2009-06-09  6:44                   ` Wu Fengguang
2009-05-19  7:15           ` Wu Fengguang
2009-05-19  7:20             ` KOSAKI Motohiro
2009-05-19  7:49               ` Wu Fengguang
2009-05-19  8:06                 ` KOSAKI Motohiro
2009-05-19  8:53                   ` Wu Fengguang
2009-05-19 12:28                     ` KOSAKI Motohiro
2009-05-20  1:44                       ` Wu Fengguang [this message]
2009-05-20  1:59                         ` KOSAKI Motohiro
2009-05-20  2:31                           ` Wu Fengguang
2009-05-20  2:58                             ` KOSAKI Motohiro
2009-05-19 13:24                     ` Rik van Riel
2009-05-19 15:55                       ` KOSAKI Motohiro
2009-05-19  6:39   ` Pekka Enberg
2009-05-19  6:56     ` KOSAKI Motohiro
2009-05-19  7:44     ` Peter Zijlstra
2009-05-19  8:05       ` Pekka Enberg
2009-05-19  8:12         ` Wu Fengguang
2009-05-19  8:14           ` Pekka Enberg
2009-05-19 13:14     ` Rik van Riel
2009-05-16  9:00 ` [PATCH 3/3] vmscan: merge duplicate code in shrink_active_list() Wu Fengguang
2009-05-16 13:39   ` Johannes Weiner
2009-05-16 13:47     ` Wu Fengguang
2009-05-16 14:35   ` Rik van Riel
2009-05-17  1:24   ` Minchan Kim
2009-05-16 14:56 ` [PATCH 0/3] make mapped executable pages the first class citizen Peter Zijlstra
2009-06-17 21:11   ` Jesse Barnes
2009-06-17 21:37     ` Jesse Barnes
2009-06-18  1:25     ` Wu Fengguang
2009-06-18 16:33       ` Jesse Barnes
2009-06-19  9:00       ` Wu, Fengguang
2009-06-19  9:04         ` Peter Zijlstra
2009-06-19  9:32           ` Wu Fengguang
2009-06-19 16:43             ` Jesse Barnes
2009-07-04  1:27               ` Roger WANG
2009-07-06 17:38                 ` Jesse Barnes
  -- strict thread matches above, loose matches on Subject: below --
2009-05-17  2:23 Wu Fengguang
2009-05-17  2:23 ` [PATCH 2/3] vmscan: " Wu Fengguang
2009-05-19  8:59   ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090520014445.GA7645@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=elladan@eskimo.com \
    --cc=hannes@cmpxchg.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=npiggin@suse.de \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).