From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756300AbZETIJB (ORCPT ); Wed, 20 May 2009 04:09:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754628AbZETIIq (ORCPT ); Wed, 20 May 2009 04:08:46 -0400 Received: from one.firstfloor.org ([213.235.205.2]:32888 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754342AbZETIIp (ORCPT ); Wed, 20 May 2009 04:08:45 -0400 Date: Wed, 20 May 2009 10:14:43 +0200 From: Andi Kleen To: Chris Peterson Cc: Andi Kleen , linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [RFC] mod_timer() helper functions? Message-ID: <20090520081443.GA8684@one.firstfloor.org> References: <87eiumq3w2.fsf@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > /** > * timer_settime_msecs - modify a timer's timeout > * @timer: the timer to be modified > * @msecs: minimum time in milliseconds to sleep for > */ > int timer_settime_msecs(struct timer_list *timer, int msecs) At least this function needs something that indicates it is very approximate (upto 900% error for 1ms with HZ=100) The old open coded pattern showed this. Or perhaps better drop the msecs version and just keep the seconds version. People who want msecs accuracy likely should use hrtimers anyways. -Andi -- ak@linux.intel.com -- Speaking for myself only.