From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
peterz@infradead.org
Subject: Re: [PATCH] include KERN_* constant in printk calls
Date: Wed, 20 May 2009 10:37:19 +0200 [thread overview]
Message-ID: <20090520083719.GG6736@elte.hu> (raw)
In-Reply-To: <20090520043215.GA3077@chrisubuntu-laptop>
* Chris Sanford <crsanford@gmail.com> wrote:
> On Tue, May 19 09 11:00, Ingo Molnar wrote:
> >
> > * Chris Sanford <crsanford@gmail.com> wrote:
> >
> > > Add the KERN_CONT constant to two printk calls.
> > >
> > > Signed-off-by: Chris Sanford <crsanford@gmail.com>
> > >
> > > ---
> > >
> > >
> > > diff --git a/kernel/sched.c b/kernel/sched.c
> > > index 26efa47..6a2ed16 100644
> > > --- a/kernel/sched.c
> > > +++ b/kernel/sched.c
> > > @@ -7319,7 +7319,7 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
> > > printk(KERN_DEBUG "%*s domain %d: ", level, "", level);
> > >
> > > if (!(sd->flags & SD_LOAD_BALANCE)) {
> > > - printk("does not load-balance\n");
> > > + printk(KERN_CONT "does not load-balance\n");
> > > if (sd->parent)
> > > printk(KERN_ERR "ERROR: !SD_LOAD_BALANCE domain"
> > > " has parent");
> > > @@ -7340,7 +7340,7 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
> > > printk(KERN_DEBUG "%*s groups:", level + 1, "");
> > > do {
> > > if (!group) {
> > > - printk("\n");
> > > + printk(KERN_CONT "\n");
> > > printk(KERN_ERR "ERROR: group is NULL\n");
> > > break;
> >
> > Please use pr_cont() - and while at it, perhaps convert all other
> > printk()s in sched.c from KERN_* to the pr_*() notation as well?
> >
> > Thanks,
> >
> > Ingo
> > --
>
> The KERN_DEBUG constant is used 5 times when DEBUG is undefined.
> Doing a straight conversion from printk(KERN_DEBUG to pr_debug(
> will result in no messages being printed. Should these calls have
> a different message type, should DEBUG be defined, or should
> something else be done?
good point - i think it's fine to change it to pr_info().
Ingo
next prev parent reply other threads:[~2009-05-20 8:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 23:31 [PATCH] include KERN_* constant in printk calls Chris Sanford
2009-05-19 9:00 ` Ingo Molnar
2009-05-20 4:32 ` Chris Sanford
2009-05-20 8:37 ` Ingo Molnar [this message]
2009-05-21 2:46 ` Chris Sanford
2009-05-21 3:30 ` Joe Perches
2009-05-21 4:09 ` Chris Sanford
2009-05-21 5:09 ` Michael Ellerman
2009-05-21 9:09 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520083719.GG6736@elte.hu \
--to=mingo@elte.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).