From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755556AbZETKVl (ORCPT ); Wed, 20 May 2009 06:21:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755783AbZETKVd (ORCPT ); Wed, 20 May 2009 06:21:33 -0400 Received: from gir.skynet.ie ([193.1.99.77]:32930 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756563AbZETKVc (ORCPT ); Wed, 20 May 2009 06:21:32 -0400 Date: Wed, 20 May 2009 11:21:29 +0100 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , KOSAKI Motohiro , Rik van Riel , Johannes Weiner Subject: Re: [PATCH 1/3] clean up setup_per_zone_pages_min Message-ID: <20090520102129.GA12433@csn.ul.ie> References: <20090520161853.1bfd415c.minchan.kim@barrios-desktop> <20090520085416.GA27056@csn.ul.ie> <20090520185803.e5b0698a.minchan.kim@barrios-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20090520185803.e5b0698a.minchan.kim@barrios-desktop> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2009 at 06:58:03PM +0900, Minchan Kim wrote: > Hi, Mel. > > On Wed, 20 May 2009 09:54:16 +0100 > Mel Gorman wrote: > > > On Wed, May 20, 2009 at 04:18:53PM +0900, Minchan Kim wrote: > > > > > > Mel changed zone->pages_[high/low/min] with zone->watermark array. > > > So, setup_per_zone_pages_min also have to be changed. > > > > > > > Just to be clear, this is a function renaming to match the new zone > > field name, not something I missed. As the function changes min, low and > > max, a better name might have been setup_per_zone_watermarks but whether > > At first, I thouht, too. But It's handle of min_free_kbytes. > Documentation said, it's to compute a watermark[WMARK_MIN]. > I think many people already used that knob to contorl pages_min to keep the > low pages. Which documentation? I'm looking at the function comment and see * setup_per_zone_pages_min - called when min_free_kbytes changes. * * Ensures that the pages_{min,low,high} values for each zone are set * correctly with respect to min_free_kbytes. So, the values of all the watermarks are updated by that function depending on what the new value of min_free_kbytes is. It is a bit wrong I suppose as it missed memory hot-add setup_per_zone_pages_min - called when min_free_kbytes changes or when memory is hot-added > > So, I determined function name is proper now. > If setup_per_zone_watermark is better than it, we also have to change with > documentation. > > > you go with that name or not, this is better than what is there so; > > > > Acked-by: Mel Gorman > > > -- > Kinds Regards > Minchan Kim > -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab