From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756504AbZETW7b (ORCPT ); Wed, 20 May 2009 18:59:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753229AbZETW7X (ORCPT ); Wed, 20 May 2009 18:59:23 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:55103 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbZETW7W (ORCPT ); Wed, 20 May 2009 18:59:22 -0400 Date: Wed, 20 May 2009 18:59:21 -0400 From: Christoph Hellwig To: Steven Rostedt Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Frederic Weisbecker , Li Zefan , Eduard - Gabriel Munteanu , Pekka Enberg Subject: Re: [PATCH 1/3] tracing: add __print_flags for events Message-ID: <20090520225921.GA15167@infradead.org> References: <20090515210342.488025506@goodmis.org> <20090515210717.745370400@goodmis.org> <20090518173854.GA30425@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2009 at 06:13:37PM -0400, Steven Rostedt wrote: > OK, this may even save space. By passing by parameters we must load all > the parameters before calling the function. Even though this is on the > print side, it is still bloated. I'll convert it to an array. Nice, thanks. Btw, it would be nice to add a __print_symbolic cousin that looks for an exact match in an array. That way we can also print translations to names in a way that can be read from the format file and duplicated by userspace apps using the binary trace buffer.