From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Jason Baron <jbaron@redhat.com>
Subject: [PATCH 5/5] tracing: convert irq events to use __print_symbolic
Date: Wed, 20 May 2009 23:17:16 -0400 [thread overview]
Message-ID: <20090521031749.639465433@goodmis.org> (raw)
In-Reply-To: 20090521031711.494593605@goodmis.org
[-- Attachment #1: 0005-tracing-convert-irq-events-to-use-__print_symbolic.patch --]
[-- Type: text/plain, Size: 2122 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
The recording of the names at trace time is inefficient. This patch
implements the softirq event recording to only record the vector
and then use the __print_symbolic interface to print out the names.
[ Impact: faster recording of softirq events ]
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/trace/events/irq.h | 23 +++++++++++++++++------
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
index 32a9f7e..683fb36 100644
--- a/include/trace/events/irq.h
+++ b/include/trace/events/irq.h
@@ -7,6 +7,19 @@
#undef TRACE_SYSTEM
#define TRACE_SYSTEM irq
+#define softirq_name(sirq) { sirq, #sirq }
+#define show_softirq_name(val) \
+ __print_symbolic(val, \
+ softirq_name(HI_SOFTIRQ), \
+ softirq_name(TIMER_SOFTIRQ), \
+ softirq_name(NET_TX_SOFTIRQ), \
+ softirq_name(NET_RX_SOFTIRQ), \
+ softirq_name(BLOCK_SOFTIRQ), \
+ softirq_name(TASKLET_SOFTIRQ), \
+ softirq_name(SCHED_SOFTIRQ), \
+ softirq_name(HRTIMER_SOFTIRQ), \
+ softirq_name(RCU_SOFTIRQ))
+
/**
* irq_handler_entry - called immediately before the irq action handler
* @irq: irq number
@@ -87,15 +100,14 @@ TRACE_EVENT(softirq_entry,
TP_STRUCT__entry(
__field( int, vec )
- __string( name, softirq_to_name[h-vec] )
),
TP_fast_assign(
__entry->vec = (int)(h - vec);
- __assign_str(name, softirq_to_name[h-vec]);
),
- TP_printk("softirq=%d action=%s", __entry->vec, __get_str(name))
+ TP_printk("softirq=%d action=%s", __entry->vec,
+ show_softirq_name(__entry->vec))
);
/**
@@ -117,15 +129,14 @@ TRACE_EVENT(softirq_exit,
TP_STRUCT__entry(
__field( int, vec )
- __string( name, softirq_to_name[h-vec] )
),
TP_fast_assign(
__entry->vec = (int)(h - vec);
- __assign_str(name, softirq_to_name[h-vec]);
),
- TP_printk("softirq=%d action=%s", __entry->vec, __get_str(name))
+ TP_printk("softirq=%d action=%s", __entry->vec,
+ show_softirq_name(__entry->vec))
);
#endif /* _TRACE_IRQ_H */
--
1.6.2.4
--
next prev parent reply other threads:[~2009-05-21 3:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 3:17 [PATCH 0/5] [GIT PULL] tracing: print event flags and symbols Steven Rostedt
2009-05-21 3:17 ` [PATCH 1/5] tracing: add __print_flags for events Steven Rostedt
2009-05-21 3:17 ` [PATCH 2/5] tracing: add previous task state info to sched switch event Steven Rostedt
2009-05-21 3:17 ` [PATCH 3/5] tracing: add flag output for kmem events Steven Rostedt
2009-05-21 3:17 ` [PATCH 4/5] tracing: add __print_symbolic to trace events Steven Rostedt
2009-05-21 3:17 ` Steven Rostedt [this message]
2009-05-21 5:35 ` [PATCH 5/5] tracing: convert irq events to use __print_symbolic Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090521031749.639465433@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox