From: Gregory Haskins <ghaskins@novell.com>
To: avi@redhat.com
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
sfr@canb.auug.org.au, kvm@vger.kernel.org
Subject: [PATCH v2--refid=<20090521172122.bb12027c.sfr@canb.auug.org.au>] kvm: fix irqfd build failure discovered in linux-next
Date: Thu, 21 May 2009 09:27:24 -0400 [thread overview]
Message-ID: <20090521132723.8177.20321.stgit@dev.haskins.net> (raw)
Stephen Rothwell noted a build failure in arch != x86 in last nights
linux-next tree, as noted here:
http://lkml.org/lkml/2009/5/21/32
This patch corrects the build issue by requiring explicit support for
IRQFD to be defined, and only defining it on x86 (the only arch fully
supported). The code itself isnt architecture dependent, but we need
to add a new file to each makefile, advertise the capability, and
of course, test that it works for each supported arch. We will submit
patches against each relevant arch at a later time to enable support
there as well.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
arch/x86/kvm/Kconfig | 4 ++++
include/linux/kvm_host.h | 17 +++++++++++++++++
virt/kvm/eventfd.c | 6 ++++++
virt/kvm/kvm_main.c | 2 +-
4 files changed, 28 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index 8600a09..6460091 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -8,6 +8,10 @@ config HAVE_KVM_IRQCHIP
bool
default y
+config HAVE_KVM_EVENTFD
+ bool
+ default y
+
menuconfig VIRTUALIZATION
bool "Virtualization"
depends on HAVE_KVM || X86
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 3b6caf5..28bd112 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -134,7 +134,9 @@ struct kvm {
struct list_head vm_list;
struct kvm_io_bus mmio_bus;
struct kvm_io_bus pio_bus;
+#ifdef CONFIG_HAVE_KVM_EVENTFD
struct list_head irqfds;
+#endif
struct kvm_vm_stat stat;
struct kvm_arch arch;
atomic_t users_count;
@@ -529,7 +531,22 @@ static inline void kvm_free_irq_routing(struct kvm *kvm) {}
#endif
+#ifdef CONFIG_HAVE_KVM_EVENTFD
+
+void kvm_irqfd_init(struct kvm *kvm);
int kvm_irqfd(struct kvm *kvm, int fd, int gsi, int flags);
void kvm_irqfd_release(struct kvm *kvm);
+#else
+
+static inline void kvm_irqfd_init(struct kvm *kvm) {}
+static inline int kvm_irqfd(struct kvm *kvm, int fd, int gsi, int flags)
+{
+ return -EINVAL;
+}
+
+static inline void kvm_irqfd_release(struct kvm *kvm) {}
+
+#endif /* CONFIG_HAVE_KVM_EVENTFD */
+
#endif
diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c
index 72a282e..c63ff6a 100644
--- a/virt/kvm/eventfd.c
+++ b/virt/kvm/eventfd.c
@@ -206,6 +206,12 @@ kvm_deassign_irqfd(struct kvm *kvm, int fd, int gsi)
return count ? count : -ENOENT;
}
+void
+kvm_irqfd_init(struct kvm *kvm)
+{
+ INIT_LIST_HEAD(&kvm->irqfds);
+}
+
int
kvm_irqfd(struct kvm *kvm, int fd, int gsi, int flags)
{
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index b58837d..de042cb 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -983,7 +983,7 @@ static struct kvm *kvm_create_vm(void)
atomic_inc(&kvm->mm->mm_count);
spin_lock_init(&kvm->mmu_lock);
kvm_io_bus_init(&kvm->pio_bus);
- INIT_LIST_HEAD(&kvm->irqfds);
+ kvm_irqfd_init(kvm);
mutex_init(&kvm->lock);
kvm_io_bus_init(&kvm->mmio_bus);
init_rwsem(&kvm->slots_lock);
next reply other threads:[~2009-05-21 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 13:27 Gregory Haskins [this message]
2009-05-21 13:31 ` [PATCH v2--refid=<20090521172122.bb12027c.sfr@canb.auug.org.au>] kvm: fix irqfd build failure discovered in linux-next Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090521132723.8177.20321.stgit@dev.haskins.net \
--to=ghaskins@novell.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox