* fork() && ftrace_graph_exit_task()
@ 2009-05-21 19:53 Oleg Nesterov
2009-05-24 22:16 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Oleg Nesterov @ 2009-05-21 19:53 UTC (permalink / raw)
To: Frederic Weisbecker, Ingo Molnar; +Cc: linux-kernel
What if the task with ->ret_stack != NULL calls fork(), and
copy_prcoess() fails after successfull dup_task_struct() ?
bad_fork_free: -> free_task()->ftrace_graph_exit_task() will
free the parent's ->ret_stack copied by arch_dup_task_struct(),
no?
Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: fork() && ftrace_graph_exit_task()
2009-05-21 19:53 fork() && ftrace_graph_exit_task() Oleg Nesterov
@ 2009-05-24 22:16 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2009-05-24 22:16 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Ingo Molnar, linux-kernel
On Thu, May 21, 2009 at 09:53:30PM +0200, Oleg Nesterov wrote:
> What if the task with ->ret_stack != NULL calls fork(), and
> copy_prcoess() fails after successfull dup_task_struct() ?
>
> bad_fork_free: -> free_task()->ftrace_graph_exit_task() will
> free the parent's ->ret_stack copied by arch_dup_task_struct(),
> no?
>
> Oleg.
>
Good catch, that's a rare situation but very dangerous.
I will fix it, thanks for your report!
Frederic.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-24 22:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-21 19:53 fork() && ftrace_graph_exit_task() Oleg Nesterov
2009-05-24 22:16 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox