From: Dave Jones <davej@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
x86@vger.kernel.org, Len Brown <len.brown@intel.com>,
Mike Travis <travis@sgi.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Thomas Gleixner <tglx@linutronix.de>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Subject: Re: [PATCH 2/3] arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c: Use DO_ONCE & spelling fix
Date: Thu, 21 May 2009 19:26:04 -0400 [thread overview]
Message-ID: <20090521232604.GA26150@redhat.com> (raw)
In-Reply-To: <a4b6b12afa9cf1ee6e936de5eed7cb31181553d8.1242943463.git.joe@perches.com>
On Thu, May 21, 2009 at 04:00:23PM -0700, Joe Perches wrote:
> Allows removal of printk_once.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> index 208ecf6..f569cff 100644
> --- a/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> +++ b/arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
> @@ -693,8 +693,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
> if (perf->control_register.space_id == ACPI_ADR_SPACE_FIXED_HARDWARE &&
> policy->cpuinfo.transition_latency > 20 * 1000) {
> policy->cpuinfo.transition_latency = 20 * 1000;
> - printk_once(KERN_INFO "Capping off P-state tranision"
> - " latency at 20 uS\n");
> + DO_ONCE(printk(KERN_INFO
> + "P-state transition latency capped at 20 uS\n"));
ewww. This looks pretty ugly to me. Anyone else?
Dave
next prev parent reply other threads:[~2009-05-21 23:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 23:00 [PATCH 0/3] Introduce and use DO_ONCE statement expression macro Joe Perches
2009-05-21 23:00 ` [PATCH 1/3] kernel.h: Add " Joe Perches
2009-05-21 23:27 ` Randy Dunlap
2009-05-21 23:32 ` Joe Perches
2009-05-21 23:36 ` H. Peter Anvin
2009-05-21 23:41 ` Alan Cox
2009-05-22 0:27 ` Al Viro
2009-05-22 1:09 ` Joe Perches
2009-05-25 6:45 ` Rusty Russell
2009-05-26 2:42 ` Andrew Morton
2009-05-21 23:00 ` [PATCH 2/3] arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c: Use DO_ONCE & spelling fix Joe Perches
2009-05-21 23:26 ` Dave Jones [this message]
2009-05-21 23:34 ` Joe Perches
2009-05-21 23:47 ` Dave Jones
2009-05-21 23:52 ` Joe Perches
2009-05-21 23:00 ` [PATCH 3/3] kernel.h: Remove unused printk_once Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090521232604.GA26150@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@vger.kernel.org \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=venkatesh.pallipadi@intel.com \
--cc=x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).