linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ftrace: Add task_comm support for trace_event
@ 2009-05-21  7:08 Zhaolei
  2009-05-21  7:09 ` [PATCH 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
                   ` (5 more replies)
  0 siblings, 6 replies; 30+ messages in thread
From: Zhaolei @ 2009-05-21  7:08 UTC (permalink / raw)
  To: Frederic Weisbecker, Steven Rostedt, Ingo Molnar, Tom Zanussi; +Cc: LKML

If we use trace_event alone(without function trace, .etc),
it can't output enough task command information.

Before patch:
 # echo 1 > debugfs/tracing/events/sched/sched_switch/enable
 # cat debugfs/tracing/trace
 # tracer: nop
 #
 #           TASK-PID    CPU#    TIMESTAMP  FUNCTION
 #              | |       |          |         |
            <...>-2289  [000] 526276.724790: sched_switch: task bash:2289 [120] ==> sshd:2287 [120]
            <...>-2287  [000] 526276.725231: sched_switch: task sshd:2287 [120] ==> bash:2289 [120]
            <...>-2289  [000] 526276.725452: sched_switch: task bash:2289 [120] ==> sshd:2287 [120]
            <...>-2287  [000] 526276.727181: sched_switch: task sshd:2287 [120] ==> swapper:0 [140]
           <idle>-0     [000] 526277.032734: sched_switch: task swapper:0 [140] ==> events/0:5 [115]
            <...>-5     [000] 526277.032782: sched_switch: task events/0:5 [115] ==> swapper:0 [140]
 ...

After patch:
 # tracer: nop
 #
 #           TASK-PID    CPU#    TIMESTAMP  FUNCTION
 #              | |       |          |         |
             bash-2269  [000] 527347.989229: sched_switch: task bash:2269 [120] ==> sshd:2267 [120]
             sshd-2267  [000] 527347.990960: sched_switch: task sshd:2267 [120] ==> bash:2269 [120]
             bash-2269  [000] 527347.991143: sched_switch: task bash:2269 [120] ==> sshd:2267 [120]
             sshd-2267  [000] 527347.992959: sched_switch: task sshd:2267 [120] ==> swapper:0 [140]
           <idle>-0     [000] 527348.531989: sched_switch: task swapper:0 [140] ==> events/0:5 [115]
         events/0-5     [000] 527348.532115: sched_switch: task events/0:5 [115] ==> swapper:0 [140]
 ...

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
---
 kernel/trace/trace_events.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 0eec0c5..df35e5e 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -85,6 +85,7 @@ static void ftrace_clear_events(void)
 
 		if (call->enabled) {
 			call->enabled = 0;
+			tracing_stop_cmdline_record();
 			call->unregfunc();
 		}
 	}
@@ -99,12 +100,14 @@ static void ftrace_event_enable_disable(struct ftrace_event_call *call,
 	case 0:
 		if (call->enabled) {
 			call->enabled = 0;
+			tracing_stop_cmdline_record();
 			call->unregfunc();
 		}
 		break;
 	case 1:
 		if (!call->enabled) {
 			call->enabled = 1;
+			tracing_start_cmdline_record();
 			call->regfunc();
 		}
 		break;
@@ -1058,6 +1061,7 @@ static void trace_module_remove_events(struct module *mod)
 			found = true;
 			if (call->enabled) {
 				call->enabled = 0;
+				tracing_stop_cmdline_record();
 				call->unregfunc();
 			}
 			if (call->event)
@@ -1262,11 +1266,13 @@ static __init void event_trace_self_tests(void)
 		}
 
 		call->enabled = 1;
+		tracing_start_cmdline_record();
 		call->regfunc();
 
 		event_test_stuff();
 
 		call->unregfunc();
+		tracing_stop_cmdline_record();
 		call->enabled = 0;
 
 		pr_cont("OK\n");
-- 
1.5.5.3



^ permalink raw reply related	[flat|nested] 30+ messages in thread
* [PATCH 0/2] [GIT PULL] tracing/events: show task comms
@ 2009-05-21 14:18 Steven Rostedt
  2009-05-21 14:18 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Steven Rostedt
  0 siblings, 1 reply; 30+ messages in thread
From: Steven Rostedt @ 2009-05-21 14:18 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ingo Molnar, Andrew Morton, Frederic Weisbecker


Ingo,

This is on top of the changes that I posted yesterday (ftrace-1), but
in its own branch.

Please pull the latest tip/tracing/ftrace-2 tree, which can be found at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
tip/tracing/ftrace-2


Zhaolei (2):
      ftrace: Add task_comm support for trace_event
      ftrace: clean up of using ftrace_event_enable_disable()

----
 kernel/trace/trace_events.c |   42 ++++++++++++++++--------------------------
 1 files changed, 16 insertions(+), 26 deletions(-)
-- 

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2009-05-27 22:37 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-21  7:08 [PATCH 1/2] ftrace: Add task_comm support for trace_event Zhaolei
2009-05-21  7:09 ` [PATCH 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-21 13:16   ` Steven Rostedt
2009-05-21 13:15 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Steven Rostedt
2009-05-22  8:01   ` Ingo Molnar
2009-05-22  8:25     ` Ingo Molnar
2009-05-22  8:49       ` Zhaolei
2009-05-22 10:03 ` [PATCH v2 0/2] " Zhaolei
2009-05-22 10:05   ` [PATCH v2 1/2] " Zhaolei
2009-05-24 20:42     ` Frederic Weisbecker
2009-05-25  3:54       ` Zhaolei
2009-05-25  8:27         ` Frederic Weisbecker
2009-05-22 10:06   ` [PATCH v2 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-24 20:46     ` Frederic Weisbecker
2009-05-25  5:34       ` Zhaolei
2009-05-25  8:32         ` Frederic Weisbecker
2009-05-22 11:51   ` [PATCH v2 0/2] ftrace: Add task_comm support for trace_event Ingo Molnar
2009-05-25  8:59     ` Zhaolei
2009-05-25 16:45       ` Frederic Weisbecker
2009-05-25 17:01         ` Frederic Weisbecker
2009-05-25 10:03     ` [PATCH v3 " Zhaolei
2009-05-25 10:11       ` [PATCH v3 1/2] " Zhaolei
2009-05-26  0:44         ` Frederic Weisbecker
2009-05-25 10:13       ` [PATCH v3 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-23 15:16 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Christoph Hellwig
2009-05-23 15:18   ` Christoph Hellwig
2009-05-27 22:34 ` [tip:tracing/core] " tip-bot for Zhaolei
2009-05-27 22:35 ` [tip:tracing/core] ftrace: clean up of using ftrace_event_enable_disable() tip-bot for Zhaolei
  -- strict thread matches above, loose matches on Subject: below --
2009-05-21 14:18 [PATCH 0/2] [GIT PULL] tracing/events: show task comms Steven Rostedt
2009-05-21 14:18 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Steven Rostedt
2009-05-24 21:41   ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).