From: Christoph Hellwig <hch@infradead.org>
To: Zhaolei <zhaolei@cn.fujitsu.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Tom Zanussi <tzanussi@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ftrace: Add task_comm support for trace_event
Date: Sat, 23 May 2009 11:18:45 -0400 [thread overview]
Message-ID: <20090523151845.GB2642@infradead.org> (raw)
In-Reply-To: <20090523151628.GA2642@infradead.org>
On Sat, May 23, 2009 at 11:16:28AM -0400, Christoph Hellwig wrote:
> On Thu, May 21, 2009 at 03:08:46PM +0800, Zhaolei wrote:
> > <...>-2289 [000] 526276.724790: sched_switch: task bash:2289 [120] ==> sshd:2287 [120]
>
> we should have a space after the colon. Also wouldn't it be better
> to place task->commit close to the pid in the output?
Sorry, please ignore this mail, it doesn't make any sense :) I took
the old example tracer output for the added comm information. The patch
does look good to me.
next prev parent reply other threads:[~2009-05-23 15:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 7:08 [PATCH 1/2] ftrace: Add task_comm support for trace_event Zhaolei
2009-05-21 7:09 ` [PATCH 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-21 13:16 ` Steven Rostedt
2009-05-21 13:15 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Steven Rostedt
2009-05-22 8:01 ` Ingo Molnar
2009-05-22 8:25 ` Ingo Molnar
2009-05-22 8:49 ` Zhaolei
2009-05-22 10:03 ` [PATCH v2 0/2] " Zhaolei
2009-05-22 10:05 ` [PATCH v2 1/2] " Zhaolei
2009-05-24 20:42 ` Frederic Weisbecker
2009-05-25 3:54 ` Zhaolei
2009-05-25 8:27 ` Frederic Weisbecker
2009-05-22 10:06 ` [PATCH v2 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-24 20:46 ` Frederic Weisbecker
2009-05-25 5:34 ` Zhaolei
2009-05-25 8:32 ` Frederic Weisbecker
2009-05-22 11:51 ` [PATCH v2 0/2] ftrace: Add task_comm support for trace_event Ingo Molnar
2009-05-25 8:59 ` Zhaolei
2009-05-25 16:45 ` Frederic Weisbecker
2009-05-25 17:01 ` Frederic Weisbecker
2009-05-25 10:03 ` [PATCH v3 " Zhaolei
2009-05-25 10:11 ` [PATCH v3 1/2] " Zhaolei
2009-05-26 0:44 ` Frederic Weisbecker
2009-05-25 10:13 ` [PATCH v3 2/2] ftrace: clean up of using ftrace_event_enable_disable() Zhaolei
2009-05-23 15:16 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Christoph Hellwig
2009-05-23 15:18 ` Christoph Hellwig [this message]
2009-05-27 22:34 ` [tip:tracing/core] " tip-bot for Zhaolei
2009-05-27 22:35 ` [tip:tracing/core] ftrace: clean up of using ftrace_event_enable_disable() tip-bot for Zhaolei
-- strict thread matches above, loose matches on Subject: below --
2009-05-21 14:18 [PATCH 0/2] [GIT PULL] tracing/events: show task comms Steven Rostedt
2009-05-21 14:18 ` [PATCH 1/2] ftrace: Add task_comm support for trace_event Steven Rostedt
2009-05-24 21:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090523151845.GB2642@infradead.org \
--to=hch@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).