From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755435AbZEWPSx (ORCPT ); Sat, 23 May 2009 11:18:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752924AbZEWPSq (ORCPT ); Sat, 23 May 2009 11:18:46 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:44004 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752359AbZEWPSq (ORCPT ); Sat, 23 May 2009 11:18:46 -0400 Date: Sat, 23 May 2009 11:18:45 -0400 From: Christoph Hellwig To: Zhaolei Cc: Frederic Weisbecker , Steven Rostedt , Ingo Molnar , Tom Zanussi , LKML Subject: Re: [PATCH 1/2] ftrace: Add task_comm support for trace_event Message-ID: <20090523151845.GB2642@infradead.org> References: <4A14FDFE.2080402@cn.fujitsu.com> <20090523151628.GA2642@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090523151628.GA2642@infradead.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 23, 2009 at 11:16:28AM -0400, Christoph Hellwig wrote: > On Thu, May 21, 2009 at 03:08:46PM +0800, Zhaolei wrote: > > <...>-2289 [000] 526276.724790: sched_switch: task bash:2289 [120] ==> sshd:2287 [120] > > we should have a space after the colon. Also wouldn't it be better > to place task->commit close to the pid in the output? Sorry, please ignore this mail, it doesn't make any sense :) I took the old example tracer output for the added comm information. The patch does look good to me.