From: Frederic Weisbecker <fweisbec@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org
Subject: Re: fork() && ftrace_graph_exit_task()
Date: Mon, 25 May 2009 00:16:16 +0200 [thread overview]
Message-ID: <20090524221615.GG6471@nowhere> (raw)
In-Reply-To: <20090521195330.GA13604@redhat.com>
On Thu, May 21, 2009 at 09:53:30PM +0200, Oleg Nesterov wrote:
> What if the task with ->ret_stack != NULL calls fork(), and
> copy_prcoess() fails after successfull dup_task_struct() ?
>
> bad_fork_free: -> free_task()->ftrace_graph_exit_task() will
> free the parent's ->ret_stack copied by arch_dup_task_struct(),
> no?
>
> Oleg.
>
Good catch, that's a rare situation but very dangerous.
I will fix it, thanks for your report!
Frederic.
prev parent reply other threads:[~2009-05-24 22:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 19:53 fork() && ftrace_graph_exit_task() Oleg Nesterov
2009-05-24 22:16 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090524221615.GG6471@nowhere \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox