Re: [RFC PATCH 7/X] ptrace: mv task->parent ptrace_task->pt_tracer

Oleg Nesterov
2009-05-28T03:39:37Z

On 05/27, Roland McGrath wrote:
>
> If you're going to zero out fields in a corner case, I think you should
> zero si_code too

Well, SI_USER == 0, so si_code is zero. And SI_USER looks more
consistent to me, because

> so it's consistent with what collect_signal() produces
> when a signal is posted with OOM for the sigq allocation.

perhaps it is better to change collect_signal() to set SI_USER ?
Note that __send_signal() user SI_USER, not zero in is_si_special()
case.

> (It is likely nobody will ever see this path anyway,
> since we'll probably merge the clean-up that replaces it before any release
> that uses this series at all.)

Yes!

But without some fix, I was really puzzled how I can make any
progress now.

You never know which change will take most time...

Oleg.