Re: [RFC PATCH 7/X] ptrace: mv task->parent ptrace_task->pt_tracer

Roland McGrath
2009-05-28T19:28:39Z

> Well, SI_USER == 0, so si_code is zero. And SI_USER looks more
> consistent to me, because

Ah so.

> > so it's consistent with what collect_signal() produces
> > when a signal is posted with OOM for the sigq allocation.
>
> perhaps it is better to change collect_signal() to set SI_USER ?
> Note that __send_signal() user SI_USER, not zero in is_si_special()
> case.

Sure, though as you point out it's purely cosmetic.

Thanks,
Roland