From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Roland McGrath <roland@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/X] ptrace: introduce the empty "struct ptrace_task"
Date: Mon, 25 May 2009 17:50:38 +0200 [thread overview]
Message-ID: <20090525155038.GA10431@redhat.com> (raw)
In-Reply-To: <20090525032426.GA20687@elte.hu>
On 05/25, Ingo Molnar wrote:
>
> * Oleg Nesterov <oleg@redhat.com> wrote:
>
> > --- PTRACE/include/linux/sched.h~3_STRUCT 2009-05-24 21:29:04.000000000 +0200
> > +++ PTRACE/include/linux/sched.h 2009-05-24 22:14:41.000000000 +0200
> > @@ -1201,6 +1201,7 @@ struct task_struct {
> > struct list_head sibling; /* linkage in my parent's children list */
> > struct task_struct *group_leader; /* threadgroup leader */
> >
> > + struct ptrace_task *ptrace_task;
> > /*
> > * ptraced is the list of tasks this task is using ptrace on.
> > * This includes both natural children and PTRACE_ATTACH targets.
>
> the naming sucks.
>
> Please use 'struct ptrace_context' and '*ptrace_ctx' instead.
As always, I agree with any naming. Will re-name in V2.
Oleg.
next prev parent reply other threads:[~2009-05-25 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 0:00 [RFC PATCH 3/X] ptrace: introduce the empty "struct ptrace_task" Oleg Nesterov
2009-05-25 3:30 ` Ingo Molnar
2009-05-25 15:50 ` Oleg Nesterov [this message]
2009-05-26 20:33 ` Roland McGrath
2009-05-26 20:48 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090525155038.GA10431@redhat.com \
--to=oleg@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).