From: Andrew Morton <akpm@linux-foundation.org>
To: Tobias_Mueller@twam.info
Cc: linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>,
Jordan Crouse <jordan@cosmicpenguin.net>,
Ben Gardner <gardner.ben@gmail.com>
Subject: Re: [PATCH 001/001] gpio: AMD CS5535/CS5536 GPIO driver
Date: Tue, 26 May 2009 15:16:21 -0700 [thread overview]
Message-ID: <20090526151621.a7446c60.akpm@linux-foundation.org> (raw)
In-Reply-To: <17be05570905230453i591eb83bnb359f6365c109718@mail.gmail.com>
On Sat, 23 May 2009 13:53:58 +0200
Tobias M__ller <Tobias_Mueller@twam.info> wrote:
> From: Tobias Mueller <Tobias_Mueller@twam.info>
>
> A GPIO driver for AMD Geode Companion Device CS5535/CS5536
> using the GPIO framework as a replacement for old cs5535-gpio driver.
It looks reasonsable from a quick scan.
The patch was somewhat wordwrapped by your email client.
The patch generates a large number of warnings when checked with
scripts/checkpatch.pl. Please take a look at that and permanently
incorporate checkpatch into your patch generation tools.
Please cc the following individuals on future versions of this patch:
David Brownell <david-b@pacbell.net>
Jordan Crouse <jordan@cosmicpenguin.net>
Ben Gardner <gardner.ben@gmail.com>
> index edb0253..0b7ef6f 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -67,6 +67,14 @@ config GPIO_SYSFS
>
> comment "Memory mapped GPIO expanders:"
>
> +config GPIO_CS5535
> + tristate "AMD CS5535/CS5536 (Geode Companion Device)"
> + depends on !CONFIG_CS5535_GPIO && X86 && EXPERIMENTAL
> + default N
> + help
> + Say yes here to support GPIO pins of AMD CS5535/CS5536
> + (Geode Companion Device)
We'll need to discuss the migration plan - we don't want to maintain
two drivers for the same thing.
next prev parent reply other threads:[~2009-05-26 22:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 11:53 [PATCH 001/001] gpio: AMD CS5535/CS5536 GPIO driver Tobias Müller
2009-05-26 22:16 ` Andrew Morton [this message]
2009-05-30 18:05 ` [PATCH v2 " Tobias Müller
2009-06-01 23:54 ` Andrew Morton
2009-06-02 0:08 ` Andres Salomon
2009-06-02 3:02 ` Jordan Crouse
2009-06-02 8:14 ` Tobias Müller
2009-06-02 20:33 ` Andrew Morton
2009-06-09 12:27 ` Tobias Müller
2009-06-10 4:00 ` Andres Salomon
2009-06-02 0:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526151621.a7446c60.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Tobias_Mueller@twam.info \
--cc=david-b@pacbell.net \
--cc=gardner.ben@gmail.com \
--cc=jordan@cosmicpenguin.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox