From: Andrew Morton <akpm@linux-foundation.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: ben-linux@fluff.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] S3C: beyond ARRAY_SIZE of s3c_gpios
Date: Tue, 26 May 2009 22:57:20 -0700 [thread overview]
Message-ID: <20090526225720.a1f47b4e.akpm@linux-foundation.org> (raw)
In-Reply-To: <4A1426EB.5080506@gmail.com>
On Wed, 20 May 2009 17:51:07 +0200 Roel Kluin <roel.kluin@gmail.com> wrote:
> Do not go beyond ARRAY_SIZE of s3c_gpios
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/arch/arm/plat-s3c/gpio.c b/arch/arm/plat-s3c/gpio.c
> index d71dd6d..29926c1 100644
> --- a/arch/arm/plat-s3c/gpio.c
> +++ b/arch/arm/plat-s3c/gpio.c
> @@ -28,7 +28,7 @@ static __init void s3c_gpiolib_track(struct s3c_gpio_chip *chip)
>
> gpn = chip->chip.base;
> for (i = 0; i < chip->chip.ngpio; i++, gpn++) {
> - BUG_ON(gpn > ARRAY_SIZE(s3c_gpios));
> + BUG_ON(gpn >= ARRAY_SIZE(s3c_gpios));
> s3c_gpios[gpn] = chip;
> }
> }
umm, OK, but the title and changelog are quite inaccurate.
I rewrote the title to
s3c: fix check of index into s3c_gpios[]
and rewrote the changelog to
The check of the s3c_gpios[] index had an off-by-one.
prev parent reply other threads:[~2009-05-27 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-20 15:51 [PATCH] S3C: beyond ARRAY_SIZE of s3c_gpios Roel Kluin
2009-05-27 5:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526225720.a1f47b4e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox