From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754950AbZE0BEU (ORCPT ); Tue, 26 May 2009 21:04:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752494AbZE0BEN (ORCPT ); Tue, 26 May 2009 21:04:13 -0400 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:42258 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752168AbZE0BEN (ORCPT ); Tue, 26 May 2009 21:04:13 -0400 Date: Wed, 27 May 2009 10:03:59 +0900 From: Paul Mundt To: Mike Frysinger Cc: linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, Greg Ungerer , uclinux-dev@uclinux.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH 1/3] mtd/maps: uclinux: allow systems to override map addr/size Message-ID: <20090527010359.GA8979@linux-sh.org> Mail-Followup-To: Paul Mundt , Mike Frysinger , linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, Greg Ungerer , uclinux-dev@uclinux.org, linux-mtd@lists.infradead.org References: <20090526231902.GA6295@linux-sh.org> <1243380798-10089-1-git-send-email-vapier@gentoo.org> <20090526234616.GC6295@linux-sh.org> <200905262047.21041.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200905262047.21041.vapier@gentoo.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2009 at 08:46:24PM -0400, Mike Frysinger wrote: > On Tuesday 26 May 2009 19:46:16 Paul Mundt wrote: > > On Tue, May 26, 2009 at 07:33:16PM -0400, Mike Frysinger wrote: > > > +extern char _ebss; > > > + > > > > Also, it would be nice if the remaining architectures that define _ebss > > could shove this in their asm/sections.h so we can kill this off from the > > driver itself. > > well, everyone would still have to define the _ebss symbol otherwise they'd > get an undefined error due to how the map is initialized. Yes, but that is not the issue. The issue is that the section extern has no place in a driver, this is precisely what asm/sections.h is for. Only microblaze and sh define it there today, and there is already inconsistency. Having the others define it for themselves and agreeing on a type would permit us to kill it off from the driver.