[PATCH 04/18] scripts/get_maintainer.pl - Warn on missing git or git repository

Joe Perches
2009-05-24T02:42:00Z

support older versions of grep (use -E not -P)
no need to return data in routine recent_git_signoffs

Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/get_maintainer.pl | 15 ++++++++++++---
1 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index e733e87..fe49122 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -443,11 +443,21 @@ sub recent_git_signoffs {
my @lines = ();

if (which("git") eq "") {
- die("$P: git not found. Add --nogit to options?\n");
+ warn("$P: git not found. Add --nogit to options?\n");
+ return;
+ }
+ if (!(-d ".git")) {
+ warn("$P: .git repository not found.\n");
+ warn("Use a .git repository for better results.\n");
+ warn("ie: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git\n");
+ return;
}

$cmd = "git log --since=${email_git_since} -- ${file}";
- $cmd .= " | grep -Pi \"^[-_ a-z]+by:.*\\\@.*\$\"";
+ $cmd .= " | grep -Ei \"^[-_ a-z]+by:.*\\\@.*\$\"";
+ if (!$email_git_penguin_chiefs) {
+ $cmd .= " | grep -Ev \"${penguin_chiefs}\"";
+ }
$cmd .= " | cut -f2- -d\":\"";
$cmd .= " | sort | uniq -c | sort -rn";

@@ -486,7 +496,6 @@ sub recent_git_signoffs {
push(@email_to, $line);
}
}
- return $output;
}

sub uniq {
--
1.6.3.1.10.g659a0.dirty