Re: [PATCH -tip] Documentation/accounting/getdelays.c intialize the variable before using it

[Balbir Singh <balbir@linux.vnet.ibm.com>]

* Jaswinder Singh Rajput <jaswinder@kernel.org> [2009-05-20 10:44:44]:

> 
> May be in some cases cmd_type will be used uninitialized.
> 
> Also fixes compilation warning:
> 
>    CC [M]  Documentation/DocBook/procfs_example.o
>   Documentation/accounting/getdelays.c: In function ???main???:
>   Documentation/accounting/getdelays.c:249: warning: ???cmd_type??? may be used uninitialized in this function
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
>  Documentation/accounting/getdelays.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c
> index 7ea2311..36aae3b 100644
> --- a/Documentation/accounting/getdelays.c
> +++ b/Documentation/accounting/getdelays.c
> @@ -246,7 +246,7 @@ void print_ioacct(struct taskstats *t)
> 
>  int main(int argc, char *argv[])
>  {
> -	int c, rc, rep_len, aggr_len, len2, cmd_type;
> +	int c, rc, rep_len, aggr_len, len2, cmd_type = TASKSTATS_CMD_ATTR_UNSPEC;

Thanks. The fix seems correct


Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>

I am away traveling with almost no time to check emails, hence I've
been slow responding. Thanks for being patient. 

-- 
	Balbir