From: Gregory Haskins <ghaskins@novell.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] kvm: fix coalesced_mmio leak on shutdown
Date: Wed, 27 May 2009 12:41:12 -0400 [thread overview]
Message-ID: <20090527164059.23966.75880.stgit@dev.haskins.net> (raw)
It would appear that we are invoking kfree() on the wrong pointer in the
destructor for the coalesced_mmio device. This would result in a potential
leak during shutdown.
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
virt/kvm/coalesced_mmio.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/virt/kvm/coalesced_mmio.c b/virt/kvm/coalesced_mmio.c
index 5ae620d..03ea280 100644
--- a/virt/kvm/coalesced_mmio.c
+++ b/virt/kvm/coalesced_mmio.c
@@ -80,7 +80,10 @@ static void coalesced_mmio_write(struct kvm_io_device *this,
static void coalesced_mmio_destructor(struct kvm_io_device *this)
{
- kfree(this);
+ struct kvm_coalesced_mmio_dev *dev =
+ (struct kvm_coalesced_mmio_dev *)this->private;
+
+ kfree(dev);
}
int kvm_coalesced_mmio_init(struct kvm *kvm)
next reply other threads:[~2009-05-27 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 16:41 Gregory Haskins [this message]
2009-05-27 20:29 ` [PATCH] kvm: fix coalesced_mmio leak on shutdown Chris Wright
2009-05-27 20:32 ` Gregory Haskins
2009-05-27 20:35 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090527164059.23966.75880.stgit@dev.haskins.net \
--to=ghaskins@novell.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox