[PATCH] drm: intel: add ignore lvds quirk info for AOpen Mini PC

[PATCH] drm: intel: add ignore lvds quirk info for AOpen Mini PC

[Jarod Wilson]

Fix a FIXME in the intel LVDS bring-up code, adding the appropriate
blacklist entry for the AOpen Mini PC, courtesy of a dmidecode
dump from Florian Demmer.

Signed-off-by: Jarod Wilson <jarod@redhat.com>
CC: Florian Demmer <florian@demmer.org>

---
 drivers/gpu/drm/i915/intel_lvds.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c
index 439a865..7ac00c3 100644
--- a/drivers/gpu/drm/i915/intel_lvds.c
+++ b/drivers/gpu/drm/i915/intel_lvds.c
@@ -424,8 +424,14 @@ static const struct dmi_system_id __initdata intel_no_lvds[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
 		},
 	},
-
-	/* FIXME: add a check for the Aopen Mini PC */
+	{
+		.callback = intel_no_lvds_dmi_callback,
+		.ident = "AOpen Mini PC",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
+		},
+	},
 
 	{ }	/* terminating entry */
 };

-- 
Jarod Wilson
jarod@redhat.com

Re: [PATCH] drm: intel: add ignore lvds quirk info for AOpen Mini PC

[Jesse Barnes]

On Wed, 27 May 2009 17:20:39 -0400
Jarod Wilson <jarod@redhat.com> wrote:

> Fix a FIXME in the intel LVDS bring-up code, adding the appropriate
> blacklist entry for the AOpen Mini PC, courtesy of a dmidecode
> dump from Florian Demmer.
> 
> Signed-off-by: Jarod Wilson <jarod@redhat.com>
> CC: Florian Demmer <florian@demmer.org>
> 
> ---
>  drivers/gpu/drm/i915/intel_lvds.c |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_lvds.c
> b/drivers/gpu/drm/i915/intel_lvds.c index 439a865..7ac00c3 100644
> --- a/drivers/gpu/drm/i915/intel_lvds.c
> +++ b/drivers/gpu/drm/i915/intel_lvds.c
> @@ -424,8 +424,14 @@ static const struct dmi_system_id __initdata
> intel_no_lvds[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
>  		},
>  	},
> -
> -	/* FIXME: add a check for the Aopen Mini PC */
> +	{
> +		.callback = intel_no_lvds_dmi_callback,
> +		.ident = "AOpen Mini PC",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
> +		},
> +	},
>  
>  	{ }	/* terminating entry */
>  };
> 

Looks fine to me, Eric?  Patches to the i915 driver should generally go
to intel-gfx@lists.freedesktop.org so we don't miss them.  Thanks.

Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Re: [PATCH] drm: intel: add ignore lvds quirk info for AOpen Mini PC

[Jarod Wilson]

On Monday 01 June 2009 07:01:26 Jesse Barnes wrote:
> Patches to the i915 driver should generally go
> to intel-gfx@lists.freedesktop.org so we don't miss them.  Thanks.

Ah, sorry, didn't know that. Might I suggest adding a note to that
effect in MAINTAINERS? Reasonably sure that's where I looked to try
to figure out where to send a prior i915 patch and I don't see a
ref to that list in there now.

-- 
Jarod Wilson
jarod@redhat.com

Re: [PATCH] drm: intel: add ignore lvds quirk info for AOpen Mini PC

[Joe Perches]

On Mon, 2009-06-01 at 11:54 -0400, Jarod Wilson wrote:
> On Monday 01 June 2009 07:01:26 Jesse Barnes wrote:
> > Patches to the i915 driver should generally go
> > to intel-gfx@lists.freedesktop.org so we don't miss them.  Thanks.

Does that apply to the i810 and i830 as well?

Re: [PATCH] drm: intel: add ignore lvds quirk info for AOpen Mini PC

[Jesse Barnes]

On Mon, 01 Jun 2009 09:11:41 -0700
Joe Perches <joe@perches.com> wrote:

> On Mon, 2009-06-01 at 11:54 -0400, Jarod Wilson wrote:
> > On Monday 01 June 2009 07:01:26 Jesse Barnes wrote:
> > > Patches to the i915 driver should generally go
> > > to intel-gfx@lists.freedesktop.org so we don't miss them.  Thanks.
> 
> Does that apply to the i810 and i830 as well?

Those drivers are fairly abandoned afaik, so I'm not sure where patches
to them should go.  In fact I think i830 is deprecated in favor of
i915... so it should probably just be killed.

Jesse