public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [Patch] kbuild: fix a compile warning
Date: Thu, 28 May 2009 00:41:00 -0700	[thread overview]
Message-ID: <20090528004100.3716e00d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090515075229.11346.6710.sendpatchset@localhost.localdomain>

On Fri, 15 May 2009 03:51:18 -0400 Amerigo Wang <amwang@redhat.com> wrote:

> 
> I got this warning:

With which gcc version?

>  HOSTCC  scripts/basic/fixdep
> scripts/basic/fixdep.c: In function 'traps':
> scripts/basic/fixdep.c:377: warning: dereferencing type-punned pointer will break strict-aliasing rules
> scripts/basic/fixdep.c:379: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 

(wtf?)

> 
> --- a/scripts/basic/fixdep.c
> +++ b/scripts/basic/fixdep.c
> @@ -373,10 +373,11 @@ void print_deps(void)
>  void traps(void)
>  {
>  	static char test[] __attribute__((aligned(sizeof(int)))) = "CONF";
> +	int *p = (int *)test;
>  
> -	if (*(int *)test != INT_CONF) {
> +	if (*p != INT_CONF) {
>  		fprintf(stderr, "fixdep: sizeof(int) != 4 or wrong endianess? %#x\n",
> -			*(int *)test);
> +			*p);
>  		exit(2);
>  	}
>  }

  reply	other threads:[~2009-05-28  7:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15  7:51 [Patch] kbuild: fix a compile warning Amerigo Wang
2009-05-28  7:41 ` Andrew Morton [this message]
2009-05-31  2:25   ` Amerigo Wang
2009-09-13 14:05     ` Felipe Contreras
2009-09-15  8:04       ` Amerigo Wang
2009-09-15  8:33         ` Felipe Contreras
2009-05-28 13:18 ` Luming Yu
2009-06-05 22:08 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090528004100.3716e00d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox