From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757318AbZE1Hot (ORCPT ); Thu, 28 May 2009 03:44:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754813AbZE1Hol (ORCPT ); Thu, 28 May 2009 03:44:41 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45413 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754764AbZE1Hok (ORCPT ); Thu, 28 May 2009 03:44:40 -0400 Date: Thu, 28 May 2009 00:44:33 -0700 From: Andrew Morton To: Harry Ciao Cc: norsk5@yahoo.com, linux-kernel@vger.kernel.org, bluesmoke-devel@lists.sourceforge.net Subject: Re: [v1 PATCH 0/2] EDAC: AMD8111 & AMD8131 Kconfig fixup Message-Id: <20090528004433.4051e83d.akpm@linux-foundation.org> In-Reply-To: <1242358006-28339-1-git-send-email-qingtao.cao@windriver.com> References: <1242358006-28339-1-git-send-email-qingtao.cao@windriver.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 May 2009 11:26:44 +0800 Harry Ciao wrote: > These are two minor fixups for the AMD8111 and AMD8131 EDAC drivers. > The direct reference to device.bus_id should be replaced by dev_name(). > > Add their missing Makefile entires and introduce machine dependency to > their Kconfig options in order to avoid the allmodconfig failure, which > I have no better idea to avoid although these chips are not specific to > Maple. OK, thanks. Do you think these fixes are safe and desirable for 2.6.30? (I do).