Re: [PATCH] x86: MCE: Fix for mce_panic_timeout

Andi Kleen
2009-05-28T08:09:28Z

On Thu, May 28, 2009 at 09:52:55AM +0900, Hidetoshi Seto wrote:
> Andi Kleen wrote:
> > Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> writes:
> >> - In case of panic_timeout > 0 and mce_bootlog == 0.
> >> System should reboot after panic, but it doesn't on mce panic because
> >> current mce code overwrite panic_timeout to 0.
> >
> > Nope, with bootlog==0 it should _not_ automatically reboot on panic.
> > Automatic rebooting makes mainly sense with boot logging, otherwise
> > you will likely lose the information. Or at least the kernel
> > cannot know if you lose information or not so it has to err on
> > the safe side.
>
> Users already know they might lose the information about the panic
> if panic_timeout > 0. It is same on all kind of panic.

Yes if they set panic=..., but they don't expect it by default as
this patch does.

>
> > I changed it now to only override with panic_timeout == 0,
> > as in the user didn't set anything,
> > that's probably the most sensible semantics anyways.
>
> It's OK with me.
> The logic in this patch also seems good.

Thanks.

>
> But...
>
> > v2: Only force panic timeout when it's shorter (H.Seto)
> > v3: Only panic when there is no earlier timeout or it's not zero
> > (based on comment H.Seto)
>
> "Only panic when ..." ?
> I could not cache the meaning of this changelog.

"Only automatically panic ..."

Ok fair enough, if I ever redo a repost I'll update that line, but I hope
I don't have to touch this trivial patch anymore.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.