* [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt
@ 2009-05-28 11:35 Oleg Nesterov
2009-05-28 21:34 ` Roland McGrath
0 siblings, 1 reply; 4+ messages in thread
From: Oleg Nesterov @ 2009-05-28 11:35 UTC (permalink / raw)
To: Roland McGrath; +Cc: Christoph Hellwig, Ingo Molnar, linux-kernel
Changes:
- renames as Ingo suggested
- use task_lock() instead of cmpxchg() in _alloc()
- comments update
New patches: move last_siginfo, ptrace_message, ptrace_entry.
Oleg.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt
2009-05-28 11:35 [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt Oleg Nesterov
@ 2009-05-28 21:34 ` Roland McGrath
2009-05-29 12:05 ` Oleg Nesterov
0 siblings, 1 reply; 4+ messages in thread
From: Roland McGrath @ 2009-05-28 21:34 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Christoph Hellwig, Ingo Molnar, linux-kernel
5/12 still needs a comment about its assumption that tracehook_init_task()
allocated the struct iff appropriate. Some log entries (or maybe comments)
I saw said "->pt_*" though that is not the name of the field in the patch.
Other than the task_lock/kfree nit in 4/12 it all looks good to me so far.
Thanks,
Roland
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt
2009-05-28 21:34 ` Roland McGrath
@ 2009-05-29 12:05 ` Oleg Nesterov
2009-05-29 20:18 ` Roland McGrath
0 siblings, 1 reply; 4+ messages in thread
From: Oleg Nesterov @ 2009-05-29 12:05 UTC (permalink / raw)
To: Roland McGrath; +Cc: Christoph Hellwig, Ingo Molnar, linux-kernel
On 05/28, Roland McGrath wrote:
>
> 5/12 still needs a comment about its assumption that tracehook_init_task()
> allocated the struct iff appropriate.
Not sure I understand... Where should I put this comment?
> Some log entries (or maybe comments)
> I saw said "->pt_*" though that is not the name of the field in the patch.
Yes, the changelog for 9/12.
> Other than the task_lock/kfree nit in 4/12 it all looks good to me so far.
OK, will redo and resend. Perhaps I should send this series to you
privately? I don't like to flood lkml again, the changes are cosmetic.
Oleg.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt
2009-05-29 12:05 ` Oleg Nesterov
@ 2009-05-29 20:18 ` Roland McGrath
0 siblings, 0 replies; 4+ messages in thread
From: Roland McGrath @ 2009-05-29 20:18 UTC (permalink / raw)
To: Oleg Nesterov; +Cc: Christoph Hellwig, Ingo Molnar, linux-kernel
> > 5/12 still needs a comment about its assumption that tracehook_init_task()
> > allocated the struct iff appropriate.
>
> Not sure I understand... Where should I put this comment?
ptrace_init_task, to explain this line:
- if (unlikely(ptrace)) {
+ if (unlikely(child->ptrace_ctx)) {
> OK, will redo and resend. Perhaps I should send this series to you
> privately? I don't like to flood lkml again, the changes are cosmetic.
:-) Whatever you like. They will surely be posted at least twice more
before they get merged either way. The idea that any actual useful patches
might pollute the purity of the lkml stream is amusing. (Post them twice,
it will nudge up the signal-to-noise ratio. ;-)
Thanks,
Roland
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-05-29 20:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-28 11:35 [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt Oleg Nesterov
2009-05-28 21:34 ` Roland McGrath
2009-05-29 12:05 ` Oleg Nesterov
2009-05-29 20:18 ` Roland McGrath
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox