Re: [my_cpu_ptr 1/5] Introduce my_cpu_ptr()

Christoph Hellwig
2009-05-28T16:10:42Z

On Thu, May 28, 2009 at 01:16:01PM +0930, Rusty Russell wrote:
> On Thu, 28 May 2009 03:16:59 am cl@linux-foundation.org wrote:
> > my_cpu_ptr(xx) = per_cpu_ptr(xx, smp_processor_id).
>
> I had this implemented earlier as as get_cpu_ptr()/__get_cpu_ptr(), to match
> get_cpu_var() / __get_cpu_var().
>
> But other than that nomenclature quibble, it looks fine!

my_ seems a very odd naming. We have a lot of this_cpu naming for the
current cpu i nthe ctree, so I would suggest sticking to that.