public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Rob van der Heij <rvdheij@gmail.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	john stultz <johnstul@us.ibm.com>
Subject: [patch 0/2] NOHZ vs. profile/oprofile
Date: Thu, 28 May 2009 17:04:47 +0200	[thread overview]
Message-ID: <20090528150447.152019714@de.ibm.com> (raw)

Greetings,
Rob pointed me to a deficiency with the current profile/oprofile
code together with NOHZ. For us this problem crept in with the
conversion of s390 to generic clock events, git commit 5a62b192
If the system is running with the HZ-tick disabled and the cpu spents
time in idle we see skewed percentages e.g. with the oprofile output.
On an I/O bound system the number of idle ticks is way to small. The
reason is that the generic clock events code reports either zero or
one tick to profile/oprofile on wakeup from idle even if the cpu has
slept much longer.
I've tried to fix that with the two patches in this series and
another pure s390 specific fix (profile_tick is called from
clock_comparator_work which is nonsense). These three do correct the
oprofile output on s390. The best idea I had to get oprofile in good
shape again is to let the system tick at the HZ rate while oprofile
is working. Better ideas welcome.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


             reply	other threads:[~2009-05-28 15:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28 15:04 Martin Schwidefsky [this message]
2009-05-28 15:04 ` [patch 1/2] idle profile hits with NOHZ Martin Schwidefsky
2009-05-28 20:19   ` Thomas Gleixner
2009-05-29 12:56     ` Martin Schwidefsky
2009-05-29 13:15       ` Thomas Gleixner
2009-05-28 15:04 ` [patch 2/2] keep on ticking if oprofile is active Martin Schwidefsky
2009-05-28 20:29   ` Thomas Gleixner
2009-05-29 12:57     ` Martin Schwidefsky
2009-05-29 13:14       ` Thomas Gleixner
2009-06-01  8:09   ` Andi Kleen
2009-06-01 10:22     ` Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090528150447.152019714@de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rvdheij@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox