From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763988AbZE1UYc (ORCPT ); Thu, 28 May 2009 16:24:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756638AbZE1UYZ (ORCPT ); Thu, 28 May 2009 16:24:25 -0400 Received: from kroah.org ([198.145.64.141]:58285 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754857AbZE1UYY (ORCPT ); Thu, 28 May 2009 16:24:24 -0400 Date: Thu, 28 May 2009 13:14:50 -0700 From: Greg KH To: Ming Lei Cc: Alan Cox , linux-kernel@vger.kernel.org Subject: Re: [PATCH] driver core : fix request_firmware_nowait Message-ID: <20090528201450.GA4043@kroah.com> References: <1243004787-5362-1-git-send-email-tom.leiming@gmail.com> <20090522161016.36ef6f15@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 22, 2009 at 11:26:16PM +0800, Ming Lei wrote: > 2009/5/22 Alan Cox : > > On Fri, 22 May 2009 23:06:27 +0800 > > tom.leiming@gmail.com wrote: > > > >> From: Ming Lei > >> > >> request_firmware_nowait declares it can be called in non-sleep contexts, > >> but kthead_run which is called by request_firmware_nowait may sleep. > > > > Does anyone actually need to call it in a non-sleeping context or can the > > documentation simply be fixed instead to avoid all the extra complexity ? > > > > It seems no one calls it in a non-sleeping context now, but we can provide it > without much extra complexity, IMHO. Also someone has complained it : > > http://marc.info/?t=124022846400003&r=1&w=2 That was 3 years ago :) I say just fix the documentation. thanks, greg k-h