public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 4/12 v2] ptrace: introduce the empty "struct ptrace_context"
Date: Thu, 28 May 2009 14:15:40 -0700 (PDT)	[thread overview]
Message-ID: <20090528211540.2A5BAFC2BD@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Thursday, 28 May 2009 13:35:45 +0200 <20090528113545.GA18691@redhat.com>

> +	task_lock(tsk);
> +	if (likely(!tsk->ptrace_ctx))
> +		tsk->ptrace_ctx = ptrace_ctx;
> +	else
> +		kfree(ptrace_ctx);
> +	task_unlock(tsk);

I don't think it's kosher call kfree with task_lock() held.
The kfree case is a very unlikely path, so it can be:

	task_lock(tsk);
	if (likely(!tsk->ptrace_ctx)) {
		tsk->ptrace_ctx = ptrace_ctx;
		task_unlock(tsk);
		return 0;
	}

	task_unlock(tsk);
	kfree(ptrace_ctx);

Thanks,
Roland

  reply	other threads:[~2009-05-28 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28 11:35 [RFC PATCH 4/12 v2] ptrace: introduce the empty "struct ptrace_context" Oleg Nesterov
2009-05-28 21:15 ` Roland McGrath [this message]
2009-05-29 11:53   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090528211540.2A5BAFC2BD@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox