From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 11/12 v2] ptrace: mv task_struct->ptrace_message ptrace_ctx->message
Date: Thu, 28 May 2009 14:24:18 -0700 (PDT) [thread overview]
Message-ID: <20090528212418.2F605FC2BD@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Thursday, 28 May 2009 13:41:00 +0200 <20090528114100.GA18744@redhat.com>
> Perhaps it is better to optimize out "mask != 0" check in ptrace_event().
> This special !mask case is only needed for _report_clone(), we can use
> mask == PT_PTRACED instead.
Sure, that is fine. But note it should always have been compiled away
before anyway, since it's inline and constant in every caller.
Thanks,
Roland
next prev parent reply other threads:[~2009-05-28 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 11:36 [RFC PATCH 11/12 v2] ptrace: mv task_struct->ptrace_message ptrace_ctx->message Oleg Nesterov
2009-05-28 11:41 ` Oleg Nesterov
2009-05-28 21:24 ` Roland McGrath [this message]
2009-05-29 12:24 ` Oleg Nesterov
2009-05-30 18:52 ` PATCH? tracehook_report_clone: fix false positives Oleg Nesterov
2009-06-01 0:22 ` Roland McGrath
2009-06-01 20:07 ` Oleg Nesterov
2009-06-01 20:50 ` Roland McGrath
2009-06-01 21:34 ` Oleg Nesterov
2009-06-01 23:19 ` Roland McGrath
2009-06-02 0:14 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528212418.2F605FC2BD@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox