From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792AbZE1WBC (ORCPT ); Thu, 28 May 2009 18:01:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751515AbZE1WAy (ORCPT ); Thu, 28 May 2009 18:00:54 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:36882 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbZE1WAx (ORCPT ); Thu, 28 May 2009 18:00:53 -0400 Date: Fri, 29 May 2009 00:00:43 +0200 From: Ingo Molnar To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Paul Mackerras , Mike Galbraith , Thomas Gleixner , Steven Rostedt , Linux Kernel Mailing List Subject: Re: [PATCH tip 0/5] perf: make top share sym routines with report Message-ID: <20090528220043.GA20964@elte.hu> References: <20090528175451.GB4747@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090528175451.GB4747@ghostprotocols.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Arnaldo Carvalho de Melo wrote: > Haven't done and perf stat runs tho. Perhaps ask for running it > for 5 refreshes and then exit. I've benchmarked it. With about half a million sample IRQs per second on a 16way x86 box the overhead went from 22.3%: PID USER PR NI VIRT RES SHR S %CPU %MEM TIME COMMAND 4701 mingo 20 0 423m 61m 1796 R 22.3 0.5 0:08.11 perf down to: PID USER PR NI VIRT RES SHR S %CPU %MEM TIME COMMAND 3386 mingo 20 0 88068 61m 1756 R 18.2 0.5 0:03.06 perf So it's a ~22% speedup. Also, there's much less virtual memory used as well - a factor of 5 reduction (!). Applied and pushed out - thanks Arnaldo! Ingo