Re: [PATCH] driver core : fix request_firmware_nowait

Ming Lei
2009-05-29T01:24:38Z

2009/5/29 Greg KH <greg@kroah.com>:
> On Fri, May 22, 2009 at 11:26:16PM +0800, Ming Lei wrote:
>> 2009/5/22 Alan Cox <alan@lxorguk.ukuu.org.uk>:
>> > On Fri, 22 May 2009 23:06:27 +0800
>> > tom.leiming@gmail.com wrote:
>> >
>> >> From: Ming Lei <tom.leiming@gmail.com>
>> >>
>> >> request_firmware_nowait declares it can be called in non-sleep contexts,
>> >> but kthead_run which is called by request_firmware_nowait may sleep.
>> >
>> > Does anyone actually need to call it in a non-sleeping context or can the
>> > documentation simply be fixed instead to avoid all the extra complexity ?
>> >
>>
>> It seems no one calls it in a non-sleeping context now, but we can provide it
>> without much extra complexity, IMHO.  Also someone has complained it :
>>
>>       http://marc.info/?t=124022846400003&r=1&w=2
>
> That was 3 years ago :)

No, just one month ago, also the name of *_nowait is very misleading and only
documentation fix seems not enough, right?

http://marc.info/?t=124022846400003&r=1&w=2

2009-04-20 Am I allowed to call request_firmware_nowait from an
linux-ker John Hughes

>
> I say just fix the documentation.
>
> thanks,
>
> greg k-h
>

--
Lei Ming