Re: [PATCH 2/2 -tip] drm/i915: intel_lvds.c fix section mismatch warning

[Jarod Wilson <jarod@redhat.com>]

On Friday 29 May 2009 02:16:35 Jaswinder Singh Rajput wrote:
> On Thu, 2009-05-28 at 11:00 -0400, Jarod Wilson wrote:
> > On Wednesday 20 May 2009 02:27:35 Jaswinder Singh Rajput wrote:
> > > 
> > > intel_no_lvds[] does not require __initdata as it is used only by :
> > > 
> > >   void intel_lvds_init(struct drm_device *dev)
> > > 
> > > fixes section mismatch warning:
> > > 
> > >   WARNING: drivers/gpu/drm/i915/i915.o(.text+0xf3c5): Section mismatch in reference from the function intel_lvds_init() to the variable .init.data:intel_no_lvds
> > >   The function intel_lvds_init() references
> > >   the variable __initdata intel_no_lvds.
> > >   This is often because intel_lvds_init lacks a __initdata
> > 
> > This would seem to suggest __initdata should be added to
> > intel_lvds_init, rather than removed from intel_no_lvds...
> > 
> 
> The complete statement is :
> 
> WARNING: drivers/gpu/drm/i915/i915.o(.text+0xf3c5): Section mismatch in reference from the function intel_lvds_init() to the variable .init.data:intel_no_lvds
> The function intel_lvds_init() references
> the variable __initdata intel_no_lvds.
> This is often because intel_lvds_init lacks a __initdata 
> annotation or the annotation of intel_no_lvds is wrong.

Ah, yeah, I'd have kept my mouth shut if the last line were there the
first time, or at least looked at the code more to understand why you
went this direction. ;)

> I am not sure where this patch should go.
> 
> So I am also mailing to Andrew and Dave, it they find this useful then
> they can add in their tree.

Dave is on vacation a bit longer, iirc. Not entirely sure where else
this might go either. I'm sure *someone* will pick it up sooner or
later... In any case, thanks for the fix for my flub.

Acked-by: Jarod Wilson <jarod@redhat.com>

-- 
Jarod Wilson
jarod@redhat.com