public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] perf_counter: Don't swap contexts containing locked mutex
Date: Fri, 29 May 2009 14:35:04 +0200	[thread overview]
Message-ID: <20090529123504.GA32299@elte.hu> (raw)
In-Reply-To: <20090529091608.GA15278@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> try the latest Git repo (i tried 95110d7) and do this:
> 
>   make clean
>   perf stat -- make -j
> 
> that locks up for me, very quickly, with permanently stuck tasks:
> 
>    PID USER      PR  NI  VIRT  RES  SHR S  %CPU %MEM   TIME    COMMAND        
>  10748 mingo     20   0     0    0    0 R 100.4  0.0   0:06.44 chmod         
>  10756 mingo     20   0     0    0    0 R 100.4  0.0   0:06.43 touch         
> 
> looping in the remove-context retry loop.

ok, after muchos debugging and tracing this turned out to be the 
perf_counter_task_exit() in kernel/fork.c, in the fork() failure 
path. That zapped the task ctx in cpuctx and caused the next 
schedule (which is rare) to not schedule the real context out. Then, 
when the task was scheduled back in again later, we scheduled in 
already active counters. Much mayhem followed and the lockup was a 
common incarnation of that. I pushed out a couple of fixes for this.

Pekka, the symptoms appear to match your 'stuck Xorg while make -j' 
symptoms pretty accurately - so if you try latest perfcounters/core 
it might solve some of those problems as well.

	Ingo

  parent reply	other threads:[~2009-05-29 12:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29  6:06 [PATCH RFC] perf_counter: Don't swap contexts containing locked mutex Paul Mackerras
2009-05-29  8:06 ` Peter Zijlstra
2009-05-29  8:10   ` Peter Zijlstra
2009-05-29  8:13   ` Peter Zijlstra
2009-05-29  8:28     ` Peter Zijlstra
2009-05-29  8:59       ` Ingo Molnar
2009-05-29  9:16         ` Ingo Molnar
2009-05-29 11:13           ` Paul Mackerras
2009-05-29 11:17             ` Peter Zijlstra
2009-05-29 11:23             ` Paul Mackerras
2009-05-29 12:35           ` Ingo Molnar [this message]
2009-05-29 13:49             ` Pekka Enberg
2009-05-29  8:25   ` Paul Mackerras
2009-05-29 12:03 ` [tip:perfcounters/core] " tip-bot for Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090529123504.GA32299@elte.hu \
    --to=mingo@elte.hu \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox