Re: [PATCH 1/4] add swap cache interface for swap reference v2 (updated)

Balbir Singh
2009-05-30T05:21:27Z

* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-05-29 14:37:58]:

> On Fri, 29 May 2009 14:08:32 +0900
> KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > > IIUC, swap_free() at the end of shmem_writepage() should also be changed to swapcache_free().
> > >
> > Hmm!. Oh, yes. shmem_writepage()'s error path. Thank you. It will be fixed.
> >
> here.
>
> ==
>
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> In following patch, usage of swap cache will be recorded into swap_map.
> This patch is for necessary interface changes to do that.
>
> 2 interfaces:
> - swapcache_prepare()
> - swapcache_free()
> is added for allocating/freeing refcnt from swap-cache to existing
> swap entries. But implementation itself is not changed under this patch.
> At adding swapcache_free(), memcg's hook code is moved under swapcache_free().
> This is better than using scattered hooks.
>
> Changelog: v1->v2
> - fixed shmem_writepage() error path.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

Looks good to me so far

Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>

--
Balbir