public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] mtd: Delete final remnants of MTD ioctls from fs/compat_ioctl.c
@ 2009-05-29 14:30 David Woodhouse
  2009-05-29 14:56 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: David Woodhouse @ 2009-05-29 14:30 UTC (permalink / raw)
  To: Kevin Cernekee; +Cc: arnd, akpm, linux-kernel, linux-mtd

On Tue, 2009-04-14 at 21:59 -0700, Kevin Cernekee wrote:
> Move all MTD compat_ioctl logic into drivers/mtd/mtdchar.c
> 
> Depends on this patch set:
> 
> http://lkml.org/lkml/2009/4/9/52
> http://lkml.org/lkml/2009/4/9/53
> http://lkml.org/lkml/2009/4/9/54
> http://lkml.org/lkml/2009/4/9/55
> 
> Signed-off-by: Kevin Cernekee <kpc.mtd@gmail.com>
> ---
>  drivers/mtd/mtdchar.c |    3 ++-
>  fs/compat_ioctl.c     |   22 ----------------------

Er, that doesn't move stuff into mtdchar.c. It just deletes it...

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mtd: Delete final remnants of MTD ioctls from fs/compat_ioctl.c
  2009-05-29 14:30 [PATCH] mtd: Delete final remnants of MTD ioctls from fs/compat_ioctl.c David Woodhouse
@ 2009-05-29 14:56 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2009-05-29 14:56 UTC (permalink / raw)
  To: David Woodhouse; +Cc: Kevin Cernekee, akpm, linux-kernel, linux-mtd

On Friday 29 May 2009, David Woodhouse wrote:
> Er, that doesn't move stuff into mtdchar.c. It just deletes it...

The changeset comment could be a little more verbose, but it looks
correct to me. The key is calling mtd_ioctl() in the 'default:'
case of mtd_compat_ioctl(), which just treats all unhandled
ioctl numbers as compatible.

	Arnd <><

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-05-29 14:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-29 14:30 [PATCH] mtd: Delete final remnants of MTD ioctls from fs/compat_ioctl.c David Woodhouse
2009-05-29 14:56 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox